Changed DB to store node positions as Ordinals.

sync/syncable/entry.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/syncable/entry.h"
 
 #include <iomanip>
 
 #include "net/base/escape.h"
 #include "sync/syncable/base_transaction.h"
@@ skipping 111 matching lines @@
     if (kernel->ref(static_cast<BitField>(i)))
       os << g_metas_columns[i].name << ", ";
   }
   for ( ; i < STRING_FIELDS_END; ++i) {
     const std::string& field = kernel->ref(static_cast<StringField>(i));
     os << g_metas_columns[i].name << ": " << field << ", ";
   }
   for ( ; i < PROTO_FIELDS_END; ++i) {
     os << g_metas_columns[i].name << ": "
        << net::EscapePath(
               kernel->ref(static_cast<ProtoField>(i)).SerializeAsString())

[akalin, 2012/10/05 22:40:27]

did you miss my comments here re. having printable strings?

[vishwath, 2012/10/08 20:17:49]

Yeah, I'm not sure how I missed these two. Done.
On 2012/10/05 22:40:27, akalin wrote:

        << ", ";
   }
+  for ( ; i < ORDINAL_FIELDS_END; ++i) {
+    os << g_metas_columns[i].name << ": "
+       << kernel->ref(static_cast<OrdinalField>(i)).ToInternalValue()

[akalin, 2012/10/05 22:40:27]

and here?

[vishwath, 2012/10/08 20:17:49]

Done.

+       << ", ";
+  }
   os << "TempFlags: ";
   for ( ; i < BIT_TEMPS_END; ++i) {
     if (kernel->ref(static_cast<BitTemp>(i)))
       os << "#" << i - BIT_TEMPS_BEGIN << ", ";
   }
   return os;
 }
 
 }  // namespace syncable
 }  // namespace syncer