Changed DB to store node positions as Ordinals.

sync/syncable/syncable_columns.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_SYNCABLE_SYNCABLE_COLUMNS_H_
 #define SYNC_SYNCABLE_SYNCABLE_COLUMNS_H_
 
 #include "sync/syncable/entry_kernel.h"
 #include "sync/syncable/syncable_changes_version.h"
 
 namespace syncer {
 namespace syncable {
 
 struct ColumnSpec {
   const char* name;
   const char* spec;
 };
 
 // Must be in exact same order as fields in syncable.

[akalin, 2012/10/02 22:43:01]

since you're here, change 'syncable' to 'entry_kernel.h'.

 static const ColumnSpec g_metas_columns[] = {
   //////////////////////////////////////
   // int64s
   {"metahandle", "bigint primary key ON CONFLICT FAIL"},
   {"base_version", "bigint default " CHANGES_VERSION_STRING},
   {"server_version", "bigint default 0"},
-  {"server_position_in_parent", "bigint default 0"},
+  {"server_ordinal_in_parent", "blob"},

[akalin, 2012/10/02 22:43:01]

i think this should be moved down to the blobs section below.  In fact, to
differentiate them from the other fields (which are serialized protos), maybe
something like:

// Blobs (serialized protos).
{"specifics"...}
...
// Blobs (ordinals).
{"server_ordinal"...},

(Might be easiest to put the column last).

   // This is the item ID that we store for the embedding application.
   {"local_external_id", "bigint default 0"},
   // These timestamps are kept in the same format as that of the
   // protocol (ms since Unix epoch).
   {"mtime", "bigint default 0"},
   {"server_mtime", "bigint default 0"},
   {"ctime", "bigint default 0"},
   {"server_ctime", "bigint default 0"},
   //////////////////////////////////////
   // Ids
@@ skipping 29 matching lines @@
 
 static inline const char* ColumnName(int field) {
   DCHECK(field < BEGIN_TEMPS);
   return g_metas_columns[field].name;
 }
 
 }  // namespace syncable
 }  // namespace syncer
 
 #endif  // SYNC_SYNCABLE_SYNCABLE_COLUMNS_H_