chrome/browser/ui/panels/panel_browsertest.cc - Issue 10987037: Add tests for panel app icon functionaility.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/panels/panel_browsertest.cc

Issue 10987037: Add tests for panel app icon functionaility. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix mac build Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/panels/panel.cc ('k') | chrome/browser/ui/panels/panel_constants.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/bind.h"	5 #include "base/bind.h"

6 #include "base/utf_string_conversions.h"	6 #include "base/utf_string_conversions.h"

7 #include "chrome/app/chrome_command_ids.h"	7 #include "chrome/app/chrome_command_ids.h"

8 #include "chrome/browser/debugger/devtools_window.h"	8 #include "chrome/browser/debugger/devtools_window.h"

9 #include "chrome/browser/net/url_request_mock_util.h"	9 #include "chrome/browser/net/url_request_mock_util.h"

10 #include "chrome/browser/prefs/browser_prefs.h"	10 #include "chrome/browser/prefs/browser_prefs.h"

(...skipping 1671 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1682 ::MSG key_msg = { NULL, WM_KEYDOWN, ui::VKEY_W, 0 };	1682 ::MSG key_msg = { NULL, WM_KEYDOWN, ui::VKEY_W, 0 };

1683 content::NativeWebKeyboardEvent key_event(key_msg);	1683 content::NativeWebKeyboardEvent key_event(key_msg);

1684 key_event.modifiers = content::NativeWebKeyboardEvent::ControlKey;	1684 key_event.modifiers = content::NativeWebKeyboardEvent::ControlKey;

1685 #else	1685 #else

1686 content::NativeWebKeyboardEvent key_event;	1686 content::NativeWebKeyboardEvent key_event;

1687 #endif	1687 #endif

1688 panel->HandleKeyboardEvent(key_event);	1688 panel->HandleKeyboardEvent(key_event);

1689 signal.Wait();	1689 signal.Wait();

1690 EXPECT_EQ(0, panel_manager->num_panels());	1690 EXPECT_EQ(0, panel_manager->num_panels());

1691 }	1691 }

	1692
	Lei Zhang 2012/10/09 18:33:39 This file shouldn't be in the CL? This file shouldn't be in the CL? jianli 2012/10/09 18:35:33 Yes. But it would be nice to clean up the unneeded Show quoted text On 2012/10/09 18:33:39, Lei Zhang wrote: > This file shouldn't be in the CL? Yes. But it would be nice to clean up the unneeded empty line. Lei Zhang 2012/10/09 18:42:36 Err? The diff shows +1. You are adding an extra em Show quoted text On 2012/10/09 18:35:33, jianli wrote: > On 2012/10/09 18:33:39, Lei Zhang wrote: > > This file shouldn't be in the CL? > > Yes. But it would be nice to clean up the unneeded empty line. Err? The diff shows +1. You are adding an extra empty line. jianli 2012/10/09 18:44:02 Sorry, my bad. I had a wrong perception. Let me re Show quoted text On 2012/10/09 18:42:36, Lei Zhang wrote: > On 2012/10/09 18:35:33, jianli wrote: > > On 2012/10/09 18:33:39, Lei Zhang wrote: > > > This file shouldn't be in the CL? > > > > Yes. But it would be nice to clean up the unneeded empty line. > > Err? The diff shows +1. You are adding an extra empty line. Sorry, my bad. I had a wrong perception. Let me remove this file and submit a new patch to land. Thanks for catching it.
OLD	NEW