Add tests for panel app icon functionaility.

chrome/browser/ui/panels/base_panel_browser_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/base_panel_browser_test.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
+#include "base/json/json_file_value_serializer.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
 #include "base/string_number_conversions.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/panels/native_panel.h"
 #include "chrome/browser/ui/panels/panel_mouse_watcher.h"
 #include "chrome/browser/ui/panels/panel_strip.h"
@@ skipping 398 matching lines @@
       full_path,  location, *input_value, Extension::NO_FLAGS, &error);
   EXPECT_TRUE(extension.get());
   EXPECT_STREQ("", error.c_str());
   browser()->profile()->GetExtensionService()->
       OnExtensionInstalled(extension.get(), false /* not from webstore */,
                            syncer::StringOrdinal(),
                            false /* no requirement errors */);
   return extension;
 }
 
+scoped_refptr<extensions::Extension>
+BasePanelBrowserTest::LoadExtensionFromManifest(

[dcheng, 2012/09/25 21:50:27]

Is it possible to share this code with ExtensionBrowserTest? I notice we're
manually calling back OnExtensionInstalled and that makes me a little sad.

[jianli, 2012/09/25 22:50:04]

Will change BasePanelBrowserTest to inherit from ExtensionBrowserTest.

+    const FilePath::StringType& manifest_file) {
+  FilePath manifest_path;
+  PathService::Get(chrome::DIR_TEST_DATA, &manifest_path);
+  manifest_path = manifest_path.Append(kTestDir);
+  manifest_path = manifest_path.Append(manifest_file);
+
+  JSONFileValueSerializer serializer(manifest_path);
+  scoped_ptr<DictionaryValue> manifest(
+      static_cast<DictionaryValue*>(serializer.Deserialize(NULL, NULL)));
+  EXPECT_TRUE(manifest.get() != NULL);
+
+  std::string error;
+  scoped_refptr<extensions::Extension> extension(Extension::Create(
+      manifest_path.DirName(), Extension::INVALID, *manifest.get(),
+      Extension::NO_FLAGS, &error));
+  EXPECT_TRUE(extension.get());
+  EXPECT_STREQ("", error.c_str());
+  browser()->profile()->GetExtensionService()->
+      OnExtensionInstalled(extension.get(), false /* not from webstore */,
+                           syncer::StringOrdinal(),
+                           false /* no requirement errors */);
+  return extension;
+}
+
 void BasePanelBrowserTest::SetTestingAreas(const gfx::Rect& primary_screen_area,
                                            const gfx::Rect& work_area) {
   DCHECK(primary_screen_area.Contains(work_area));
   mock_display_settings_provider_->SetPrimaryScreenArea(primary_screen_area);
   mock_display_settings_provider_->SetWorkArea(
       work_area.IsEmpty() ? primary_screen_area : work_area);
 }
 
 void BasePanelBrowserTest::CloseWindowAndWait(Panel* panel) {
   // Closing a panel may involve several async tasks. Need to use
@@ skipping 31 matching lines @@
 }
 
 void BasePanelBrowserTest::MoveMouse(const gfx::Point& position) {
   PanelManager::GetInstance()->mouse_watcher()->NotifyMouseMovement(position);
 }
 
 std::string BasePanelBrowserTest::MakePanelName(int index) {
   std::string panel_name("Panel");
   return panel_name + base::IntToString(index);
 }