Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2907)

Unified Diff: chrome/browser/resources/net_internals/log_view_painter.js

Issue 10987030: Make about:net-internal's filters work a bit better. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Update comments, cleanup Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/net_internals/log_view_painter.js
===================================================================
--- chrome/browser/resources/net_internals/log_view_painter.js (revision 158398)
+++ chrome/browser/resources/net_internals/log_view_painter.js (working copy)
@@ -5,6 +5,7 @@
// TODO(eroman): put these methods into a namespace.
var printLogEntriesAsText;
+var searchLogEntriesForText;
var proxySettingsToString;
var stripCookiesAndLoginInfo;
@@ -26,12 +27,36 @@
*/
printLogEntriesAsText = function(logEntries, parent, privacyStripping,
logCreationTime) {
+ var tablePrinter = createTablePrinter(logEntries, privacyStripping,
+ logCreationTime);
+
+ // Format the table for fixed-width text.
+ tablePrinter.toText(0, parent);
+}
+
+/**
+ * Searches the table that would be output by printLogEntriesAsText for
+ * |searchString|. Seperate function since TablePrinter.toText modifies the
+ * DOM.
eroman 2012/09/25 19:59:21 Can you mention the return value?
mmenke 2012/09/25 20:12:24 Done (Also now mention that searchString much be l
+ */
+searchLogEntriesForText = function(searchString, logEntries, privacyStripping) {
+ var tablePrinter =
+ createTablePrinter(logEntries, privacyStripping, undefined);
+
+ // Format the table for fixed-width text.
+ return tablePrinter.search(searchString);
+}
+
+/**
+ * Creates TablePrinters for use by the above two functions.
eroman 2012/09/25 19:59:21 nit: TablePrinters --> TablePrinter ?
mmenke 2012/09/25 20:12:24 Done.
+ */
+function createTablePrinter(logEntries, privacyStripping, logCreationTime) {
var entries = LogGroupEntry.createArrayFrom(logEntries);
var tablePrinter = new TablePrinter();
var parameterOutputter = new ParameterOutputter(tablePrinter);
if (entries.length == 0)
- return;
+ return tablePrinter;
var startTime = timeutil.convertTimeTicksToTime(entries[0].orig.time);
@@ -81,8 +106,7 @@
addRowWithTime(tablePrinter, logCreationTime, startTime);
}
- // Format the table for fixed-width text.
- tablePrinter.toText(0, parent);
+ return tablePrinter;
}
/**

Powered by Google App Engine
This is Rietveld 408576698