Fix the failed cases in URLFetcherFileTest on Android.

net/test/remote_test_server.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/test/remote_test_server.h"
 
 #include <vector>
 
 #include "base/base_paths.h"
 #include "base/file_path.h"
@@ skipping 165 matching lines @@
     return false;
   SetPort(test_server_port);
 
   SetResourcePath(document_root, FilePath().AppendASCII("net")
                                            .AppendASCII("data")
                                            .AppendASCII("ssl")
                                            .AppendASCII("certificates"));
   return true;
 }
 
+// On Android, the document root in device is not the same as the document root
+// in host machine where test server is launched. So append DIR_SOURCE_ROOT

[wtc, 2012/10/23 18:28:31]

1. This method should be defined between Stop() and Init()
to match the declaration order in the .h file. This is
recommended by the Style Guide:

  Method definitions in the corresponding .cc file should
  be the same as the declaration order, as much as
  possible. 

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Declaration_Order

2. Change "append" to "prepend" because src_dir is before
document_root(). Alternatively, say "So append the document
root to DIR_SOURCE_ROOT here to get the ..."

3. Nit: add "the" before "device", "host machine", "test server",
and "Android device".

[Shouqun Liu, 2012/10/24 02:32:47]

Done.

+// here to get the actual path of document root on Android device.
+FilePath RemoteTestServer::GetDocumentRoot() const {
+  FilePath src_dir;
+  PathService::Get(base::DIR_SOURCE_ROOT, &src_dir);
+  return src_dir.Append(document_root());
+}
+
 }  // namespace net