Fixed problem with disappearing window controls for applications when maximizing / minimizing / max…

chrome/browser/ui/views/frame/app_non_client_frame_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/app_non_client_frame_view_aura.h"
 
 #include "base/debug/stack_trace.h"
 #include "chrome/browser/ui/views/frame/browser_frame.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "grit/ash_resources.h"
@@ skipping 232 matching lines @@
 void AppNonClientFrameViewAura::OnBoundsChanged(
     const gfx::Rect& previous_bounds) {
   if (control_widget_)
     control_widget_->GetNativeView()->SetBounds(GetControlBounds());
 }
 
 gfx::Rect AppNonClientFrameViewAura::GetControlBounds() const {
   if (!control_view_)
     return gfx::Rect();
   gfx::Size preferred = control_view_->GetPreferredSize();
-  gfx::Point location(width() - preferred.width(), 0);
-  ConvertPointToWidget(this, &location);
+  const gfx::Rect bounds =
+      control_widget_->GetTopLevelWidgetForNativeView(
+          control_widget_->GetNativeWindow())->GetWindowBoundsInScreen();
+  // Position it flush to the right side of the (parent) widget.
+  gfx::Point location(bounds.width() - preferred.width(), 0);

[sky, 2012/09/24 21:24:16]

control_widget_ is a child widget of the browser. By that I mean
control_widget_->GetNativeView()->parent() == browser_frame->GetNativeWindow().
All callers of this take the return value and do
control_widget_->GetNativeView()->SetBounds(). This means the expected
coordinates of this method are in the coordinate system of the browser frame
passed to the constructor. That isn't quite what you have here. I believe you
want:

return gfx::Rect(width() - preferred.width(), 0,
                 preferred.width(), preferred.height());

If I'm right, be sure to update the header describing what coordinates this
method returns.

[Mr4D (OOO till 08-26), 2012/09/25 14:23:50]

Well - in the case I have seen (and I can reproduce) width() returns 0. You get
to the state when you first maximize, then minimize and then restore. The reason
is (as far as I can see): The window at the time of this call is minimized and
when it gets restored it gets restored to maximized. The parent should be the
browser's window.

The way I see it is that the frame is it's own view and has therefore it's own
size. Debugging through the code confirms that. At the point of creation the
rectangle of the frame view is (0,0 - 0x0). Usually a resize is happening
shortly after which is then caught by the OnSizeChange observer. However - in
the case of the the maximize operation it is a restore to the same size as the
window was before - and thus this call is not made and the observer does not get
called. As such the view size of the frame never changes from (0,0 - 0x0). That
is the reason why I need to get the parent window's size of this frame to which
this view is attached to.

So in other words: The suggested changed does not work (and yes, I have tried it
to make sure).

   return gfx::Rect(
       location.x(), location.y(),
       preferred.width(), preferred.height());
 }
 
 void AppNonClientFrameViewAura::CloseControlWidget() {
   if (control_widget_) {
     control_widget_->Close();
     control_widget_ = NULL;
   }
 }