Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/browser/extensions/image_loading_tracker.cc

Issue 10985028: Give Chrome Web Store app an icon in its manifest file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: don't install extra files, also make chrome_app app have an icon Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/image_loading_tracker.cc
diff --git a/chrome/browser/extensions/image_loading_tracker.cc b/chrome/browser/extensions/image_loading_tracker.cc
index 865bf86682715a3f1a582f562eec531cba7b3ab9..70afdaff896437b7a77c2f6eb082378b45d7bdd9 100644
--- a/chrome/browser/extensions/image_loading_tracker.cc
+++ b/chrome/browser/extensions/image_loading_tracker.cc
@@ -13,6 +13,7 @@
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_constants.h"
+#include "chrome/common/extensions/extension_file_util.h"
#include "chrome/common/extensions/extension_resource.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/notification_service.h"
@@ -30,30 +31,6 @@ using extensions::Extension;
namespace {
-struct ComponentExtensionResource {
- const char* extension_id;
- const int resource_id;
-};
-
-const ComponentExtensionResource kSpecialComponentExtensionResources[] = {
- { extension_misc::kWebStoreAppId, IDR_WEBSTORE_ICON },
- { extension_misc::kChromeAppId, IDR_PRODUCT_LOGO_128 },
-};
-
-// Finds special component extension resource id for given extension id.
-bool FindSpecialExtensionResourceId(const std::string& extension_id,
- int* out_resource_id) {
- for (size_t i = 0; i < arraysize(kSpecialComponentExtensionResources); ++i) {
- if (extension_id == kSpecialComponentExtensionResources[i].extension_id) {
- if (out_resource_id)
- *out_resource_id = kSpecialComponentExtensionResources[i].resource_id;
- return true;
- }
- }
-
- return false;
-}
-
bool ShouldResizeImageRepresentation(
ImageLoadingTracker::ImageRepresentation::ResizeCondition resize_method,
const gfx::Size& decoded_size,
@@ -245,13 +222,6 @@ class ImageLoadingTracker::ImageLoader
////////////////////////////////////////////////////////////////////////////////
// ImageLoadingTracker
-// static
-bool ImageLoadingTracker::IsSpecialBundledExtensionId(
- const std::string& extension_id) {
- int resource_id = -1;
- return FindSpecialExtensionResourceId(extension_id, &resource_id);
-}
-
ImageLoadingTracker::ImageLoadingTracker(Observer* observer)
: observer_(observer),
next_id_(0) {
@@ -295,14 +265,6 @@ void ImageLoadingTracker::LoadImages(
it != info_list.end(); ++it) {
int resource_id = -1;
- // Load resources for special component extensions.
- if (FindSpecialExtensionResourceId(load_info.extension_id, &resource_id)) {
- if (!loader_)
- loader_ = new ImageLoader(this);
- loader_->LoadResource(*it, id, resource_id);
- continue;
- }
-
// If we don't have a path we don't need to do any further work, just
// respond back.
if (it->resource.relative_path().empty()) {
@@ -336,24 +298,8 @@ bool ImageLoadingTracker::IsComponentExtensionResource(
const Extension* extension,
const ExtensionResource& resource,
int& resource_id) const {
- if (extension->location() != Extension::COMPONENT)
- return false;
-
- FilePath directory_path = extension->path();
- FilePath relative_path = directory_path.BaseName().Append(
- resource.relative_path());
-
- for (size_t i = 0; i < kComponentExtensionResourcesSize; ++i) {
- FilePath resource_path =
- FilePath().AppendASCII(kComponentExtensionResources[i].name);
- resource_path = resource_path.NormalizePathSeparators();
-
- if (relative_path == resource_path) {
- resource_id = kComponentExtensionResources[i].value;
- return true;
- }
- }
- return false;
+ return extension_file_util::IsComponentExtensionResource(extension,
+ resource.relative_path(), resource_id);
}
void ImageLoadingTracker::OnBitmapLoaded(

Powered by Google App Engine
This is Rietveld 408576698