Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2296)

Unified Diff: ppapi/shared_impl/ppapi_permissions.cc

Issue 10984094: Hook up PpapiPermissions in more places. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ppapi/proxy/ppb_flash_proxy.cc ('K') | « ppapi/shared_impl/ppapi_permissions.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/shared_impl/ppapi_permissions.cc
diff --git a/ppapi/shared_impl/ppapi_permissions.cc b/ppapi/shared_impl/ppapi_permissions.cc
index d92f6ba99488e9f05064598ad3d926fbb646406a..475d530a0d09f13aedb5e960a2cf5598c292d9c8 100644
--- a/ppapi/shared_impl/ppapi_permissions.cc
+++ b/ppapi/shared_impl/ppapi_permissions.cc
@@ -19,10 +19,7 @@ PpapiPermissions::~PpapiPermissions() {
// static
PpapiPermissions PpapiPermissions::AllPermissions() {
- return PpapiPermissions(
- PERMISSION_DEV |
- PERMISSION_PRIVATE |
- PERMISSION_BYPASS_USER_GESTURE);
+ return PpapiPermissions(PERMISSION_ALL_BITS);
}
bool PpapiPermissions::HasPermission(Permission perm) const {
@@ -31,6 +28,8 @@ bool PpapiPermissions::HasPermission(Permission perm) const {
// represented in the future so don't want callers making assumptions about
// bits.
uint32 perm_int = static_cast<uint32>(perm);
+ if (!perm_int)
+ return true; // You always have "no permission".
DCHECK((perm_int & (perm_int - 1)) == 0);
return !!(permissions_ & perm_int);
}
« ppapi/proxy/ppb_flash_proxy.cc ('K') | « ppapi/shared_impl/ppapi_permissions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698