Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: ppapi/proxy/plugin_dispatcher.h

Issue 10984094: Hook up PpapiPermissions in more places. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/plugin_dispatcher.h
diff --git a/ppapi/proxy/plugin_dispatcher.h b/ppapi/proxy/plugin_dispatcher.h
index 66b5e2d8b65dc5b428e04d67b5a7d85e9ad0a29a..b691b519c254d49e23c1c1297503b496e9be3234 100644
--- a/ppapi/proxy/plugin_dispatcher.h
+++ b/ppapi/proxy/plugin_dispatcher.h
@@ -83,8 +83,18 @@ class PPAPI_PROXY_EXPORT PluginDispatcher
// will be automatically called when requested by the renderer side. The
// module ID will be set upon receipt of the InitializeModule message.
//
+ // Note about permissions: On the host side, the dispatcher and the plugin
bbudge 2012/10/01 17:32:01 s/host/plugin?
+ // run in the same address space (including in nacl). This means that the
+ // permissions here are subject to malicious modification and bypass, and
+ // an exploited or malicious plugin could send any IPC messages and just
+ // bypass the permissions. All permissions must be checked "for realz" in the
+ // host process when receiving messages. We check them on the plugin side
+ // primarily to keep honest plugins honest, especially with respect to
+ // dev interfaces that they "shouldn't" be using.
+ //
// You must call InitPluginWithChannel after the constructor.
PluginDispatcher(PP_GetInterface_Func get_interface,
+ const PpapiPermissions& permissions,
bool incognito);
virtual ~PluginDispatcher();

Powered by Google App Engine
This is Rietveld 408576698