src/arm/simulator-arm.cc - Issue 10984057: Replace a set of Hydrogen instructions with rotate instructions on ARM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/simulator-arm.cc

Issue 10984057: Replace a set of Hydrogen instructions with rotate instructions on ARM (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/simulator-arm.cc

===================================================================

--- src/arm/simulator-arm.cc (revision 12582)

+++ src/arm/simulator-arm.cc (working copy)

@@ -1498,7 +1498,14 @@

}

case ROR: {

- UNIMPLEMENTED();

+ if (shift_amount == 0) {

+ *carry_out = c_flag_;

+ } else {

+ uint32_t left = static_cast<uint32_t>(result) >> shift_amount;

+ uint32_t right = static_cast<uint32_t>(result) << (32 - shift_amount);

+ result = right | left;

+ *carry_out = (static_cast<uint32_t>(result) >> 31) != 0;

+ }

break;

}

« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/flag-definitions.h » ('j') | no next file with comments »