Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: src/arm/simulator-arm.cc

Issue 10984057: Replace a set of Hydrogen instructions with rotate instructions on ARM (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/arm/simulator-arm.cc
===================================================================
--- src/arm/simulator-arm.cc (revision 12582)
+++ src/arm/simulator-arm.cc (working copy)
@@ -1498,10 +1498,18 @@
}
case ROR: {
- UNIMPLEMENTED();
+ if (shift_amount == 0) {
+ *carry_out = c_flag_;
+ } else {
+ int32_t left = result >> shift_amount;
Erik Corry 2012/09/27 14:45:44 How does this work with a negative input?
+ int32_t right = result << (32 - shift_amount);
+ result = right | left;
+ *carry_out = false;
ulan 2012/09/27 14:55:30 The carry_out should contain the last shifted bit
+ }
break;
}
ulan 2012/09/27 14:55:30 We can remove this empty line.
+
default: {
UNREACHABLE();
break;
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/hydrogen.h » ('j') | src/hydrogen.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698