Use a singleton 1x1 offscreen surface for all TextureImageTransportSurface instances.

content/common/gpu/texture_image_transport_surface.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/texture_image_transport_surface.h"
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
 #include "content/common/gpu/gl_scoped_binders.h"
 #include "content/common/gpu/gpu_channel.h"
 #include "content/common/gpu/gpu_channel_manager.h"
 #include "content/common/gpu/gpu_messages.h"
 #include "content/common/gpu/sync_point_manager.h"
 #include "content/public/common/content_switches.h"
 #include "gpu/command_buffer/service/context_group.h"
 #include "gpu/command_buffer/service/gpu_scheduler.h"
 #include "gpu/command_buffer/service/texture_manager.h"
 
 using gpu::gles2::ContextGroup;
 using gpu::gles2::TextureManager;
 typedef TextureManager::TextureInfo TextureInfo;
 
+scoped_refptr<gfx::GLSurface> TextureImageTransportSurface::surface_;

[piman, 2012/09/24 21:18:36]

We don't allow non-POD globals.

[hshi1, 2012/09/24 21:38:40]

In Patch Set #2 I've moved the global singleton to GpuChannelManager, does this
work for you?

Note that I've yet to address your comment regarding
GpuCommandBufferStub::OnInitialize(). Thanks.

+
 TextureImageTransportSurface::Texture::Texture()
     : client_id(0),
       sent_to_client(false) {
 }
 
 TextureImageTransportSurface::Texture::~Texture() {
 }
 
 TextureImageTransportSurface::TextureImageTransportSurface(
     GpuChannelManager* manager,
@@ skipping 46 matching lines @@
     texture_manager->SetParameter(
         texture.info, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
     texture_manager->SetParameter(
         texture.info, GL_TEXTURE_MAG_FILTER, GL_LINEAR);
     texture_manager->SetParameter(
         texture.info, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
     texture_manager->SetParameter(
         texture.info, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
   }
 
-  surface_ = gfx::GLSurface::CreateOffscreenGLSurface(false, gfx::Size(1, 1));
+  if (!surface_.get())
+    surface_ = gfx::GLSurface::CreateOffscreenGLSurface(false, gfx::Size(1, 1));
+  else
+    surface_->AddRef();
+
   if (!surface_.get())
     return false;
 
   if (!helper_->Initialize())
     return false;
 
   const CommandLine* command_line = CommandLine::ForCurrentProcess();
   if (command_line->HasSwitch(switches::kUIPrioritizeInGpuProcess))
     helper_->SetPreemptByCounter(parent_channel->MessagesPendingCount());
 
   return true;
 }
 
 void TextureImageTransportSurface::Destroy() {
   if (parent_stub_) {
     parent_stub_->decoder()->MakeCurrent();
     ReleaseParentStub();
   }
 
   if (surface_.get()) {
-    surface_->Destroy();
-    surface_ = NULL;
+    if (surface_->HasOneRef()) {
+      surface_->Destroy();
+      surface_ = NULL;
+    } else {
+      surface_->Release();
+    }
   }
 
   helper_->Destroy();
 }
 
 bool TextureImageTransportSurface::Resize(const gfx::Size&) {
   return true;
 }
 
 bool TextureImageTransportSurface::IsOffscreen() {
@@ skipping 391 matching lines @@
     Texture& texture = textures_[i];
     texture.info = NULL;
     if (!texture.sent_to_client)
       continue;
     GpuHostMsg_AcceleratedSurfaceRelease_Params params;
     params.identifier = texture.client_id;
     helper_->SendAcceleratedSurfaceRelease(params);
   }
   parent_stub_ = NULL;
 }