Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: src/regexp-macro-assembler-ia32.h

Issue 10984: Fix native code Irregexp on MacOSX. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/regexp-macro-assembler-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/regexp-macro-assembler-ia32.h
===================================================================
--- src/regexp-macro-assembler-ia32.h (revision 853)
+++ src/regexp-macro-assembler-ia32.h (working copy)
@@ -88,12 +88,14 @@
private:
// Offsets from ebp of arguments to function.
- static const int kBackup_edi = 1 * sizeof(uint32_t);
- static const int kBackup_esi= 2 * sizeof(uint32_t);
- static const int kInputBuffer = 4 * sizeof(uint32_t);
- static const int kInputStartOffset = 5 * sizeof(uint32_t);
- static const int kInputEndOffset = 6 * sizeof(uint32_t);
- static const int kRegisterOutput = 7 * sizeof(uint32_t);
+ static const int kBackup_ebx = sizeof(uint32_t);
Lasse Reichstein 2008/11/27 09:26:09 I'm wondering whether sizeof(uint32_t) should be r
+ static const int kBackup_edi = kBackup_ebx + sizeof(uint32_t);
+ static const int kBackup_esi = kBackup_edi + sizeof(uint32_t);
+ static const int kReturn_eip = kBackup_esi + sizeof(uint32_t);
+ static const int kInputBuffer = kReturn_eip + sizeof(uint32_t);
+ static const int kInputStartOffset = kInputBuffer + sizeof(uint32_t);
+ static const int kInputEndOffset = kInputStartOffset + sizeof(uint32_t);
+ static const int kRegisterOutput = kInputEndOffset + sizeof(uint32_t);
// Initial size of code buffer.
static const size_t kRegExpCodeSize = 1024;
« no previous file with comments | « no previous file | src/regexp-macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698