Issue 10984: Fix native code Irregexp on MacOSX.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10984: Fix native code Irregexp on MacOSX. (Closed)

Created:
12 years ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix native code Irregexp on MacOSX. Committed: http://code.google.com/p/v8/source/detail?r=855

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -12 lines)			Patch
M	src/regexp-macro-assembler-ia32.h	View	1 chunk	+8 lines, -6 lines	1 comment	Download
M	src/regexp-macro-assembler-ia32.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	test/cctest/cctest.status	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

12 years ago (2008-11-27 09:26:08 UTC) #2

LGTM.
Good catch. That one can't have been easy!

http://codereview.chromium.org/10984/diff/1/3
File src/regexp-macro-assembler-ia32.h (right):

http://codereview.chromium.org/10984/diff/1/3#newcode91
Line 91: static const int kBackup_ebx = sizeof(uint32_t);
I'm wondering whether sizeof(uint32_t) should be replaced by kPointerSize
instead.

Expand Messages | Collapse Messages