Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Unified Diff: android_webview/lib/aw_browser_dependency_factory_impl.h

Issue 10983004: Fix warnings when compiling with clang (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/android/cookie_getter_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/lib/aw_browser_dependency_factory_impl.h
diff --git a/android_webview/lib/aw_browser_dependency_factory_impl.h b/android_webview/lib/aw_browser_dependency_factory_impl.h
index 4b9a00371d823a9e0ca1c00239d9d999a23391e6..dbcdaaebc18760238962ecb3ea9448b63b8af718 100644
--- a/android_webview/lib/aw_browser_dependency_factory_impl.h
+++ b/android_webview/lib/aw_browser_dependency_factory_impl.h
@@ -31,8 +31,7 @@ class AwBrowserDependencyFactoryImpl : public AwBrowserDependencyFactory {
virtual content::WebContents* CreateWebContents(bool incognito) OVERRIDE;
virtual AwContentsContainer* CreateContentsContainer(
content::WebContents* contents) OVERRIDE;
- virtual content::JavaScriptDialogCreator* GetJavaScriptDialogCreator()
- OVERRIDE;
+ virtual content::JavaScriptDialogCreator* GetJavaScriptDialogCreator();
joth 2012/09/24 21:39:46 this must indicate a bug. yaron, can you advise wh
Yaron 2012/09/24 21:42:28 Ha, didn't look at this file.. the function should
private:
void InitializeNetworkDelegateOnIOThread(
@@ -51,4 +50,3 @@ class AwBrowserDependencyFactoryImpl : public AwBrowserDependencyFactory {
} // namespace android_webview
#endif // ANDROID_WEBVIEW_LIB_BROWSER_DELEGATE_IMPL_H_
-
« no previous file with comments | « no previous file | content/browser/android/cookie_getter_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698