Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5777)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/browser.cc

Issue 10980002: Mac Web Intents Part 1: Show extension download progress (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | chrome/browser/ui/intents/web_intent_picker_controller.h » ('j') | chrome/browser/ui/intents/web_intent_picker_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index c668ed687a7bb706fd47db6511ba221e126e05a4..3f54239df75c68c0afb5561edc0f0d97880fc58f 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -1429,6 +1429,13 @@ int Browser::GetExtraRenderViewHeight() const {
void Browser::OnStartDownload(WebContents* source,
content::DownloadItem* download) {
+ if (!download->ShouldShowInDownloadsUI()) {
+ fprintf(stderr, "%s skipping\n", __PRETTY_FUNCTION__);
Greg Billock 2012/10/02 19:12:20 Take out printfs.
sail 2012/10/02 19:14:51 Done. Oops, removed.
+ return;
+ } else {
+ fprintf(stderr, "%s NOT skipping\n", __PRETTY_FUNCTION__);
+ }
+
WebContents* constrained = GetConstrainingWebContents(source);
if (constrained != source) {
// Download in a constrained popup is shown in the tab that opened it.
« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | chrome/browser/ui/intents/web_intent_picker_controller.h » ('j') | chrome/browser/ui/intents/web_intent_picker_model.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698