Mac Web Intents Part 1: Show extension download progress

chrome/browser/ui/browser.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shellapi.h>
 #endif  // OS_WIN
@@ skipping 1403 matching lines @@
 void Browser::RenderWidgetShowing() {
   window_->DisableInactiveFrame();
 }
 
 int Browser::GetExtraRenderViewHeight() const {
   return window_->GetExtraRenderViewHeight();
 }
 
 void Browser::OnStartDownload(WebContents* source,
                               content::DownloadItem* download) {
+  if (!download_util::GetShouldShowInShelf(download))
+    return;

[Nico, 2012/09/25 03:07:18]

test

[sail, 2012/10/02 20:24:38]

Done.
Added a DownloadTest.HiddenDownload test.

+
   WebContents* constrained = GetConstrainingWebContents(source);
   if (constrained != source) {
     // Download in a constrained popup is shown in the tab that opened it.
     constrained->GetDelegate()->OnStartDownload(constrained, download);
     return;
   }
 
   if (!window())
     return;
 
@@ skipping 852 matching lines @@
   if (contents && !allow_js_access) {
     contents->web_contents()->GetController().LoadURL(
         target_url,
         content::Referrer(),
         content::PAGE_TRANSITION_LINK,
         std::string());  // No extra headers.
   }
 
   return contents != NULL;
 }