Mac Web Intents Part 1: Show extension download progress

chrome/browser/download/download_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Download utilities.
 
 #ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_UTIL_H_
 #define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_UTIL_H_
 
 #include <string>
@@ skipping 170 matching lines @@
 
   CHROME_DOWNLOAD_SOURCE_LAST_ENTRY,
 };
 
 // Increment one of the above counts.
 void RecordDownloadCount(ChromeDownloadCountTypes type);
 
 // Record initiation of a download from a specific source.
 void RecordDownloadSource(ChromeDownloadSource source);
 
+// Check whether a download should be displayed in the download shelf.
+bool GetShouldShowInShelf(content::DownloadItem* item);

[Nico, 2012/09/25 03:07:18]

nit: getshould sounds a bit awkward. just shouldshowinshelf.

[Steve McKay, 2012/09/25 18:56:04]

A thought about naming. Whether the shelf should show or not is a behavior we
want based on a property of this download item. So instead of naming this WRT
the behavior we want, we could name it according to the kind of property we need
to make the decision. This avoids situations in the future where callers need
access to the same property for non-shelf reasons.

e.g. We could tag the download with "inprocess", "hidden", "system", or slightly
more specific "intent-data".

HasHiddenProperty(downloaditem)
SetHiddenProperty(downloaditem, bool)

or

HasInProcessProperty(downloaditem)
SetInProcessProperty(downloaditem, bool)

[sail, 2012/10/02 18:57:01]

Done.
Removed code.

[sail, 2012/10/02 18:57:01]

I added a DownloadItem::ShouldShowInDownloadsUI() field. It sounds like there's
more refactoring coming soon so maybe it's not worth adding extra properties
here. Let me know if you think I should change this. Thanks

[Steve McKay, 2012/10/02 19:19:22]

You missed my point about finding the intrinsic property behind the immediate
need. If you name it "ShouldShowInDownloadsUI" other callers won't be able to
depend on the method...without it being a hack. If you name these according to
the intrinsic property ("IsHiddenDownload"), it's instantly shareable across
multiple uses. Think API, not "make it work for what I need".

Does that make sense?

[sail, 2012/10/02 20:24:38]

Sounds good. Renamed to DownloadItem::SetIsHiddenDownload().

+
+// Set whether a download should be displayed in the download shelf.
+void SetShouldShowInShelf(content::DownloadItem* item, bool should_show);
+
 }  // namespace download_util
 
 #endif  // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_UTIL_H_