Mac Web Intents Part 1: Show extension download progress

chrome/browser/download/download_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Download utility implementation
 
 #define _USE_MATH_DEFINES  // For VC++ to get M_PI. This has to be first.
 
 #include "chrome/browser/download/download_util.h"
 
@@ skipping 57 matching lines @@
 #endif
 
 #if defined(USE_AURA)
 #include "ui/aura/client/drag_drop_client.h"
 #include "ui/aura/root_window.h"
 #include "ui/aura/window.h"
 #endif
 
 namespace {
 
+// Key used to attach ShowInShelfData to a DownloadItem.
+const char kShowInShelfKey[] = "chrome.download_util.show_in_shelf";
+
+// Class that tracks the "show in download shelf" setting for a download item.
+class ShowInShelfData : public base::SupportsUserData::Data {
+ public:
+  explicit ShowInShelfData(bool should_show) : should_show_(should_show) {
+  }
+
+  bool should_show() const { return should_show_; }
+
+ private:
+  const bool should_show_;
+};
+
 // Get the opacity based on |animation_progress|, with values in [0.0, 1.0].
 // Range of return value is [0, 255].
 int GetOpacity(double animation_progress) {
   DCHECK(animation_progress >= 0 && animation_progress <= 1);
 
   // How many times to cycle the complete animation. This should be an odd
   // number so that the animation ends faded out.
   static const int kCompleteAnimationCycles = 5;
   double temp = animation_progress * kCompleteAnimationCycles * M_PI + M_PI_2;
   temp = sin(temp) / 2 + 0.5;
@@ skipping 389 matching lines @@
 void RecordDownloadCount(ChromeDownloadCountTypes type) {
   UMA_HISTOGRAM_ENUMERATION(
       "Download.CountsChrome", type, CHROME_DOWNLOAD_COUNT_TYPES_LAST_ENTRY);
 }
 
 void RecordDownloadSource(ChromeDownloadSource source) {
   UMA_HISTOGRAM_ENUMERATION(
       "Download.SourcesChrome", source, CHROME_DOWNLOAD_SOURCE_LAST_ENTRY);
 }
 
+bool GetShouldShowInShelf(content::DownloadItem* item) {
+  ShowInShelfData* data =
+      static_cast<ShowInShelfData*>(item->GetUserData(kShowInShelfKey));

[Greg Billock, 2012/09/25 07:15:46]

Do we not have a type token wrapper for getting data out of one of these by
type?

[sail, 2012/10/02 18:57:01]

Done.
Removed code.

+  return !data || data->should_show();
+}
+
+void SetShouldShowInShelf(content::DownloadItem* item, bool should_show) {
+  item->SetUserData(kShowInShelfKey, new ShowInShelfData(should_show));

[Nico, 2012/09/25 03:07:18]

Can't you just add a bool to DownloadItem?

[Steve McKay, 2012/09/25 18:56:04]

That'd probably work if you generalize the property to something NOT "shelf"
related. See my comment in the header file.

Then you could simply revert these changes and inspect the property directly.

[sail, 2012/10/02 18:57:01]

Done.
Added DownloadItem::ShouldShowInDownloadsUI()

+}
+
 }  // namespace download_util