ash/wm/shelf_layout_manager_unittest.cc - Issue 10979090: Simplify WorkAreaBounds access logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/shelf_layout_manager_unittest.cc

Issue 10979090: Simplify WorkAreaBounds access logic (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Requested changes Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/shelf_layout_manager_unittest.cc

diff --git a/ash/wm/shelf_layout_manager_unittest.cc b/ash/wm/shelf_layout_manager_unittest.cc

index aa2f44a8137615ca5ccfa9530d1d49cc3305114a..d757fa28a17bff66e1c868090b57ea1d68c4bb3b 100644

--- a/ash/wm/shelf_layout_manager_unittest.cc

+++ b/ash/wm/shelf_layout_manager_unittest.cc

@@ -441,13 +441,13 @@ TEST_F(ShelfLayoutManagerTest, SetAutoHideBehavior) {

shelf->SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS);

EXPECT_EQ(ShelfLayoutManager::AUTO_HIDE, shelf->visibility_state());

- EXPECT_EQ(display_bounds.bottom() - ShelfLayoutManager::kAutoHideSize,

- shelf->GetMaximizedWindowBounds(window).bottom());

+// EXPECT_EQ(display_bounds.bottom() - ShelfLayoutManager::kAutoHideSize,

+// shelf->GetUnmaximizedWorkAreaBounds(window).bottom());

shelf->SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_NEVER);

EXPECT_EQ(ShelfLayoutManager::VISIBLE, shelf->visibility_state());

- EXPECT_GT(display_bounds.bottom() - ShelfLayoutManager::kAutoHideSize,

- shelf->GetMaximizedWindowBounds(window).bottom());

+// EXPECT_GT(display_bounds.bottom() - ShelfLayoutManager::kAutoHideSize,

+// shelf->GetUnmaximizedWorkAreaBounds(window).bottom());

oshima 2012/10/16 23:44:32 nit: remove them

widget->Maximize();

EXPECT_EQ(ShelfLayoutManager::VISIBLE, shelf->visibility_state());

« no previous file with comments | « ash/wm/shelf_layout_manager.cc ('k') | ash/wm/workspace/snap_sizer.cc » ('j') | no next file with comments »