Simplify WorkAreaBounds access logic

Remove GetUnmaximizedWorkAreaBounds (use GetDisplayWorkAreaBoundsInParent) and update GetMaximizedWindowBounds to account for the simplified Autohide behavior.

BUG=151417
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162624

[Harry McCleave, 2012-09-29 01:34:33]

Ready for review.

[sky, 2012-10-01 14:11:47]

https://codereview.chromium.org/10979090/diff/2001/ash/screen_ash.cc
File ash/screen_ash.cc (right):

https://codereview.chromium.org/10979090/diff/2001/ash/screen_ash.cc#newcode41
ash/screen_ash.cc:41: gfx::Rect
ScreenAsh::GetMaximizedWindowBoundsInParent(aura::Window* window) {
Can't you nuke this entirely and folks instead use work_area on Display?

[oshima, 2012-10-15 04:45:04]

https://codereview.chromium.org/10979090/diff/5001/ash/screen_ash.cc
File ash/screen_ash.cc (right):

https://codereview.chromium.org/10979090/diff/5001/ash/screen_ash.cc#newcode43
ash/screen_ash.cc:43: return
gfx::Screen::GetDisplayNearestWindow(window).work_area();
GetDisplayWorkAreaBoundsInParent(window)

https://codereview.chromium.org/10979090/diff/5001/ash/screen_ash.cc#newcode50
ash/screen_ash.cc:50: aura::Window* window) {
Remove this method and replace with GetDisplayWorkAreaBoundsInParent(window)

[Harry McCleave, 2012-10-16 23:32:55]

On 2012/10/15 04:45:04, oshima wrote:
> https://codereview.chromium.org/10979090/diff/5001/ash/screen_ash.cc
> File ash/screen_ash.cc (right):
> 
> https://codereview.chromium.org/10979090/diff/5001/ash/screen_ash.cc#newcode43
> ash/screen_ash.cc:43: return
> gfx::Screen::GetDisplayNearestWindow(window).work_area();
> GetDisplayWorkAreaBoundsInParent(window)
> 
> https://codereview.chromium.org/10979090/diff/5001/ash/screen_ash.cc#newcode50
> ash/screen_ash.cc:50: aura::Window* window) {
> Remove this method and replace with GetDisplayWorkAreaBoundsInParent(window)

Done

[oshima, 2012-10-16 23:44:32]

lgtm with one nit

http://codereview.chromium.org/10979090/diff/13001/ash/wm/shelf_layout_manage...
File ash/wm/shelf_layout_manager_unittest.cc (right):

http://codereview.chromium.org/10979090/diff/13001/ash/wm/shelf_layout_manage...
ash/wm/shelf_layout_manager_unittest.cc:450: //           
shelf->GetUnmaximizedWorkAreaBounds(window).bottom());
nit: remove them

[sky, 2012-10-17 13:39:01]

http://codereview.chromium.org/10979090/diff/16002/ash/screen_ash.h
File ash/screen_ash.h (left):

http://codereview.chromium.org/10979090/diff/16002/ash/screen_ash.h#oldcode32
ash/screen_ash.h:32: static gfx::Rect
GetMaximizedWindowBoundsInParent(aura::Window* window);
Aren't you going to remove this too (at least your description makes it sound
that way).

[Harry McCleave, 2012-10-17 19:57:49]

On 2012/10/17 13:39:01, sky wrote:
> http://codereview.chromium.org/10979090/diff/16002/ash/screen_ash.h
> File ash/screen_ash.h (left):
> 
> http://codereview.chromium.org/10979090/diff/16002/ash/screen_ash.h#oldcode32
> ash/screen_ash.h:32: static gfx::Rect
> GetMaximizedWindowBoundsInParent(aura::Window* window);
> Aren't you going to remove this too (at least your description makes it sound
> that way).

Initially I was but it looks like the logic there needs to be maintained for
multiple display systems. So I have updated the cl description.

[Daniel Erat, 2012-10-17 20:49:20]

LGTM with the disclaimer that I haven't looked at this code before.

[commit-bot: I haz the power, 2012-10-17 20:53:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/10979090/16002

[sky, 2012-10-17 21:06:36]

LGTM

[commit-bot: I haz the power, 2012-10-18 00:21:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harrym@chromium.org/10979090/22003

[commit-bot: I haz the power, 2012-10-18 02:45:24]

Change committed as 162624