content/browser/android/surface_texture_peer_browser_impl.cc - Issue 10979047: Upstream fullscreen video implementation for android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/surface_texture_peer_browser_impl.cc

Issue 10979047: Upstream fullscreen video implementation for android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove some unused variables and make fullscreen video to work with content shell Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/surface_texture_peer_browser_impl.cc

diff --git a/content/browser/android/surface_texture_peer_browser_impl.cc b/content/browser/android/surface_texture_peer_browser_impl.cc

index a68286df08b6e8fc247b8d5a5e9a6e6429f303ea..d0eef94e284583147e828a7d7b2a6a061375bea3 100644

--- a/content/browser/android/surface_texture_peer_browser_impl.cc

+++ b/content/browser/android/surface_texture_peer_browser_impl.cc

@@ -38,9 +38,9 @@ static void SetSurfacePeer(jobject j_surface,

if (host) {

media::MediaPlayerBridge* player =

host->media_player_manager()->GetPlayer(player_id);

- if (player) {

- player->SetVideoSurface(j_surface);

- }

+ if (player &&

+ player != host->media_player_manager()->GetFullscreenPlayer())

+ player->SetVideoSurface(j_surface);

scherkus (not reviewing) 2012/10/02 16:20:16 nit: if statements > 1 line need {}

qinmin 2012/10/03 02:32:48 Done.

}