Propagate storage partition id and persistence to the browser.

content/renderer/browser_plugin/browser_plugin.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/browser_plugin/browser_plugin.h"
 
 #include "base/message_loop.h"
 #include "base/string_util.h"
 #if defined (OS_WIN)
 #include "base/sys_info.h"
@@ skipping 80 matching lines @@
   }
 }
 
 std::string BrowserPlugin::GetSrcAttribute() const {
   return src_;
 }
 
 void BrowserPlugin::SetSrcAttribute(const std::string& src) {
   if (src == src_ && !guest_crashed_)
     return;
-  if (!src.empty() || navigate_src_sent_) {
+
+  // If we haven't created the guest yet, do so now, if |src| is not empty and
+  // we will navigate it right after creation. If |src| is empty, we can delay
+  // the creation until we acutally need it.
+  if (!navigate_src_sent_ && !src.empty()) {

[Fady Samuel, 2012/09/25 19:22:40]

You might need to update:

content/renderer/browser_plugin/browser_plugin_browsertest.cc
content/browser/browser_plugin/browser_plugin_host_browsertest.cc

[nasko, 2012/09/25 22:57:22]

Done.

+    BrowserPluginManager::Get()->Send(
+        new BrowserPluginHostMsg_CreateGuest(
+            render_view_->GetRoutingID(),
+            instance_id_,
+            parent_frame_,
+            storage_partition_id_,
+            persist_storage_));
+  }
+
+  if (navigate_src_sent_ || !src.empty()) {
     BrowserPluginManager::Get()->Send(
         new BrowserPluginHostMsg_NavigateGuest(
             render_view_->GetRoutingID(),
             instance_id_,
             parent_frame_,
             src,
             gfx::Size(width(), height())));
     // Record that we sent a NavigateGuest message to embedder. Once we send
     // such a message, subsequent SetSrcAttribute() calls must always send
     // NavigateGuest messages to the embedder (even if |src| is empty), so
@@ skipping 412 matching lines @@
                                                  void* notify_data) {
 }
 
 void BrowserPlugin::didFailLoadingFrameRequest(
     const WebKit::WebURL& url,
     void* notify_data,
     const WebKit::WebURLError& error) {
 }
 
 }  // namespace content