Propagate storage partition id and persistence to the browser.

content/browser/browser_plugin/browser_plugin_embedder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_embedder.h"
 
 #include <set>
 
 #include "base/logging.h"
 #include "base/stl_util.h"
@@ skipping 59 matching lines @@
 }
 
 void BrowserPluginEmbedder::AddGuest(int instance_id,
                                      WebContents* guest_web_contents,
                                      int64 frame_id) {
   DCHECK(guest_web_contents_by_instance_id_.find(instance_id) ==
          guest_web_contents_by_instance_id_.end());
   guest_web_contents_by_instance_id_[instance_id] = guest_web_contents;
 }
 
+void BrowserPluginEmbedder::CreateGuest(RenderViewHost* render_view_host,
+                                        int instance_id,
+                                        int64 frame_id,
+                                        std::string storage_partition_id,
+                                        bool persist_storage) {

[Fady Samuel, 2012/09/25 19:22:40]

Hmm, this isn't actually used yet?

[nasko, 2012/09/25 22:57:22]

Yes, as per our discussion, this will be a smaller CL to just add the
CreateGuest message and I will wire it to the storage partition in a separate
CL.

[Fady Samuel, 2012/09/25 23:04:38]

sgtm.

+  WebContentsImpl* guest_web_contents = NULL;
+  BrowserPluginGuest* guest = GetGuestByInstanceID(instance_id);
+  CHECK(!guest);
+
+  const std::string& host =
+      render_view_host->GetSiteInstance()->GetSite().host();
+  guest_web_contents = WebContentsImpl::CreateGuest(
+      web_contents()->GetBrowserContext(),
+      host,
+      instance_id);
+
+  guest = guest_web_contents->GetBrowserPluginGuest();
+  guest->set_embedder_render_process_host(render_view_host->GetProcess());
+
+  guest_web_contents->GetMutableRendererPrefs()->throttle_input_events = false;
+  AddGuest(instance_id, guest_web_contents, frame_id);
+  guest_web_contents->SetDelegate(guest);
+}
+
 void BrowserPluginEmbedder::NavigateGuest(RenderViewHost* render_view_host,
                                           int instance_id,
                                           int64 frame_id,
                                           const std::string& src,
                                           const gfx::Size& size) {
+  GURL url(src);
   BrowserPluginGuest* guest = GetGuestByInstanceID(instance_id);
-  WebContentsImpl* guest_web_contents = NULL;
-  GURL url(src);
-  if (!guest) {
-    const std::string& host =
-        render_view_host->GetSiteInstance()->GetSite().host();
-    guest_web_contents = WebContentsImpl::CreateGuest(
-        web_contents()->GetBrowserContext(),
-        host,
-        instance_id);
-
-    guest = guest_web_contents->GetBrowserPluginGuest();
-    guest->set_embedder_render_process_host(
-        render_view_host->GetProcess());
-
-    guest_web_contents->GetMutableRendererPrefs()->
-        throttle_input_events = false;
-    AddGuest(instance_id, guest_web_contents, frame_id);
-    guest_web_contents->SetDelegate(guest);
-  } else {
-    guest_web_contents =
-        static_cast<WebContentsImpl*>(guest->GetWebContents());
-  }
+  CHECK(guest);
+  WebContentsImpl* guest_web_contents =
+      static_cast<WebContentsImpl*>(guest->GetWebContents());
 
   // We ignore loading empty urls in web_contents.
   // If a guest sets empty src attribute after it has navigated to some
   // non-empty page, the action is considered no-op.
   // TODO(lazyboy): The js shim for browser-plugin might need to reflect empty
   // src ignoring in the shadow DOM element: http://crbug.com/149001.
   if (!src.empty()) {
     guest_web_contents->GetController().LoadURL(url,
                                                 Referrer(),
                                                 PAGE_TRANSITION_AUTO_SUBFRAME,
@@ skipping 117 matching lines @@
       bool visible = *Details<bool>(details).ptr();
       WebContentsVisibilityChanged(visible);
       break;
     }
     default:
       NOTREACHED() << "Unexpected notification type: " << type;
   }
 }
 
 }  // namespace content