Chromium Code Reviews| Index: chrome/browser/resources/shared/js/cr/ui/table/table_list.js |
| diff --git a/chrome/browser/resources/shared/js/cr/ui/table/table_list.js b/chrome/browser/resources/shared/js/cr/ui/table/table_list.js |
| index a161e2943a3a2975e19a08e6a1b8dff0e0a4ec96..f765aec6e5c0bc12e19b92a36d4019f09bbe4815 100644 |
| --- a/chrome/browser/resources/shared/js/cr/ui/table/table_list.js |
| +++ b/chrome/browser/resources/shared/js/cr/ui/table/table_list.js |
| @@ -71,9 +71,10 @@ cr.define('cr.ui.table', function() { |
| }, |
| renderFunction_: function(dataItem, table) { |
| + // Warning, this function is very tricky and ugly. It can be modified by |
| + // cr.ui.Table. We must not access `this` here, since it may be anything. |
|
James Hawkins
2012/10/01 02:12:56
nit: Don't use pronouns (we) in comments; pronouns
mtomasz
2012/10/01 02:50:55
Subjectivity? We must not access `this`, this is e
James Hawkins
2012/10/01 13:50:20
The part you removed was subjective. Thanks for f
|
| var cm = table.columnModel; |
| var listItem = List.prototype.createItem.call(table.list, ''); |
| - |
| listItem.className = 'table-row'; |
| for (var i = 0; i < cm.size; i++) { |