chrome/browser/resources/shared/js/cr/ui/table/table_list.js - Issue 10977032: Screen reader now reads the file manager selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/shared/js/cr/ui/table/table_list.js

Issue 10977032: Screen reader now reads the file manager selection. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/shared/js/cr/ui/table/table_list.js

diff --git a/chrome/browser/resources/shared/js/cr/ui/table/table_list.js b/chrome/browser/resources/shared/js/cr/ui/table/table_list.js

index c8b9b1a1f3dfdfb15e46fa1c514f98b951f5173f..1e6e73e492a937a492c7d593b5413fcc4c74ed20 100644

--- a/chrome/browser/resources/shared/js/cr/ui/table/table_list.js

+++ b/chrome/browser/resources/shared/js/cr/ui/table/table_list.js

@@ -71,9 +71,10 @@ cr.define('cr.ui.table', function() {

renderFunction_: function(dataItem, table) {

+ // Warning, this function is very tricky and ugly. It can be modified by

+ // cr.ui.Table. We must not access `this` here, since it may be anything.

var cm = table.columnModel;

- var listItem = new ListItem({label: ''});

+ var listItem = cr.ui.List.prototype.createItem.call(table.list, '');

listItem.className = 'table-row';

for (var i = 0; i < cm.size; i++) {