Screen reader now reads the file manager selection.

chrome/browser/resources/shared/js/cr/ui/table.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview This implements a table control.
  */
 
 cr.define('cr.ui', function() {
   /** @const */ var ListSelectionModel = cr.ui.ListSelectionModel;
@@ skipping 150 matching lines @@
      */
     setColumnWidth: function(index, width) {
       this.columnWidths_[index] = width;
     },
 
     /**
      * Initializes the element.
      */
     decorate: function() {
       this.list_ = this.ownerDocument.createElement('list');
+      this.appendChild(this.list_);
       TableList.decorate(this.list_);
       this.list_.selectionModel = new ListSelectionModel(this);
       this.list_.table = this;
 
       this.header_ = this.ownerDocument.createElement('div');
+      this.appendChild(this.header_);

[James Hawkins, 2012/10/01 02:12:56]

Why did you make this change?

[mtomasz, 2012/10/01 02:50:55]

We have to append the list to the DOM tree before we decorate it, because list
decorate method traverses DOM tree to find the first ancestor with set id.

       TableHeader.decorate(this.header_);
       this.header_.table = this;
 
       this.classList.add('table');
-      this.appendChild(this.header_);
-      this.appendChild(this.list_);
       this.ownerDocument.defaultView.addEventListener(
           'resize', this.header_.updateWidth.bind(this.header_));
 
       this.boundResize_ = this.resize.bind(this);
       this.boundHandleSorted_ = this.handleSorted_.bind(this);
       this.boundHandleChangeList_ = this.handleChangeList_.bind(this);
 
       // The contained list should be focusable, not the table itself.
       if (this.hasAttribute('tabindex')) {
         this.list_.setAttribute('tabindex', this.getAttribute('tabindex'));
@@ skipping 129 matching lines @@
    * because table contents can contain controls that can be focused, and for
    * some purposes (e.g., styling), the table can still be conceptually focused
    * at that point even though it doesn't actually have the page focus.
    */
   cr.defineProperty(Table, 'hasElementFocus', cr.PropertyKind.BOOL_ATTR);
 
   return {
     Table: Table
   };
 });