website_settings: Fix Website Settings popup for chrome://bookmarks.

chrome/browser/ui/cocoa/website_settings_bubble_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/website_settings_bubble_controller.h"
 
 #include <cmath>
 
 #import <AppKit/AppKit.h>
 
@@ skipping 1119 matching lines @@
 void WebsiteSettingsUIBridge::set_bubble_controller(
     WebsiteSettingsBubbleController* controller) {
   bubble_controller_ = controller;
 }
 
 void WebsiteSettingsUIBridge::Show(gfx::NativeWindow parent,
                                    Profile* profile,
                                    TabContents* tab_contents,
                                    const GURL& url,
                                    const content::SSLStatus& ssl) {
   bool is_internal_page = url.SchemeIs(chrome::kChromeInternalScheme) ||

[tfarina, 2012/09/24 19:19:03]

Why InternalChromePage is not used here?

[markusheintz_, 2012/09/24 19:21:02]

InternalChromePage should be used here as well. Please use it. Thanks!

-                          url.SchemeIs(chrome::kChromeUIScheme);
+                          url.SchemeIs(chrome::kChromeUIScheme) ||
+                          url.SchemeIs(chrome::kExtensionScheme);
 
   // Create the bridge. This will be owned by the bubble controller.
   WebsiteSettingsUIBridge* bridge = new WebsiteSettingsUIBridge();
 
   // Create the bubble controller. It will dealloc itself when it closes.
   WebsiteSettingsBubbleController* bubble_controller =
       [[WebsiteSettingsBubbleController alloc] initWithParentWindow:parent
           websiteSettingsUIBridge:bridge
           tabContents:tab_contents
           isInternalPage:is_internal_page];
@@ skipping 30 matching lines @@
   [bubble_controller_ setPermissionInfo:permission_info_list];
 }
 
 void WebsiteSettingsUIBridge::SetFirstVisit(const string16& first_visit) {
   [bubble_controller_ setFirstVisit:first_visit];
 }
 
 void WebsiteSettingsUIBridge::SetSelectedTab(TabId tab_id) {
   [bubble_controller_ setSelectedTab:tab_id];
 }