chrome/browser/ui/website_settings/website_settings_utils.cc - Issue 10973013: website_settings: Fix Website Settings popup for chrome://bookmarks.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/website_settings/website_settings_utils.cc

Issue 10973013: website_settings: Fix Website Settings popup for chrome://bookmarks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/website_settings/website_settings_utils.h"	5 #include "chrome/browser/ui/website_settings/website_settings_utils.h"

6	6

	7 #include "chrome/common/extensions/extension_constants.h"

7 #include "chrome/common/url_constants.h"	8 #include "chrome/common/url_constants.h"

8 #include "googleurl/src/gurl.h"	9 #include "googleurl/src/gurl.h"

9	10

10 // Returns true if the passed \|url\| refers to an internal chrome page.	11 // Returns true if the passed \|url\| refers to an internal chrome page.

11 bool InternalChromePage(const GURL& url) {	12 bool InternalChromePage(const GURL& url) {

12 return url.SchemeIs(chrome::kChromeInternalScheme) \|\|	13 return url.SchemeIs(chrome::kChromeInternalScheme) \|\|

13 url.SchemeIs(chrome::kChromeUIScheme);	14 url.SchemeIs(chrome::kChromeUIScheme) \|\|

	15 (url.SchemeIs(chrome::kExtensionScheme) &&

	16 url.host() == extension_misc::kBookmarkManagerId);
	markusheintz_ 2012/09/24 18:36:21 I think we only need to test for url.SchemeIs(chro I think we only need to test for url.SchemeIs(chrome::kExtensionScheme). I think the website settings UI should not be displayed for any URL starting with the scheme "chrome-extension". Also this method us unfortunatly not used by Mac (see chrome/browser/ui/cocoa/website_settings_controller.mm But I think I can fix this in a separate CL. tfarina 2012/09/24 19:19:03 Done. Show quoted text On 2012/09/24 18:36:21, markusheintz_ wrote: > I think we only need to test for url.SchemeIs(chrome::kExtensionScheme). > > I think the website settings UI should not be displayed for any URL starting > with the scheme "chrome-extension". > > Also this method us unfortunatly not used by Mac (see > chrome/browser/ui/cocoa/website_settings_controller.mm > > But I think I can fix this in a separate CL. Done.
14 }	17 }

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »