Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2436)

Unified Diff: chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc

Issue 10972002: chrome: Add TabModalConfirmDialog interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc
diff --git a/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc b/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc
index 192fc44b7166cf183aa96705cf458d112a576406..0834f5cbd1b5a71a70bd7b19a250c8b14ebdf050 100644
--- a/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc
+++ b/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc
@@ -41,8 +41,8 @@ TabModalConfirmDialogTest::TabModalConfirmDialogTest()
void TabModalConfirmDialogTest::SetUpOnMainThread() {
delegate_ = new MockTabModalConfirmDialogDelegate(
chrome::GetActiveWebContents(browser()));
- dialog_ = CreateTestDialog(delegate_,
- chrome::GetActiveTabContents(browser()));
+ dialog_ = TabModalConfirmDialog::Create(
+ delegate_, chrome::GetActiveTabContents(browser()));
content::RunAllPendingInMessageLoop();
}
@@ -51,37 +51,14 @@ void TabModalConfirmDialogTest::CleanUpOnMainThread() {
::testing::Mock::VerifyAndClearExpectations(delegate_);
}
-// On Mac OS, these methods need to be compiled as Objective-C++, so they're in
-// a separate file.
-#if !defined(OS_MACOSX)
-TabModalConfirmDialog* TabModalConfirmDialogTest::CreateTestDialog(
- TabModalConfirmDialogDelegate* delegate, TabContents* tab_contents) {
- return new TabModalConfirmDialog(delegate, tab_contents);
-}
-
-void TabModalConfirmDialogTest::CloseDialog(bool accept) {
-#if defined(TOOLKIT_GTK)
- if (accept)
- dialog_->OnAccept(NULL);
- else
- dialog_->OnCancel(NULL);
-#else
- if (accept)
- dialog_->GetDialogClientView()->AcceptWindow();
- else
- dialog_->GetDialogClientView()->CancelWindow();
-#endif
-}
-#endif // !defined(OS_MACOSX)
-
IN_PROC_BROWSER_TEST_F(TabModalConfirmDialogTest, Accept) {
EXPECT_CALL(*delegate_, OnAccepted());
- CloseDialog(true);
+ dialog_->AcceptTabModalDialog();
}
IN_PROC_BROWSER_TEST_F(TabModalConfirmDialogTest, Cancel) {
EXPECT_CALL(*delegate_, OnCanceled());
- CloseDialog(false);
+ dialog_->CancelTabModalDialog();
}
IN_PROC_BROWSER_TEST_F(TabModalConfirmDialogTest, CancelSelf) {

Powered by Google App Engine
This is Rietveld 408576698