Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: lib/compiler/implementation/resolver.dart

Issue 10970006: Correctly handle const constructors with type parameters. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/scanner/listener.dart » ('j') | tests/co19/co19-dart2dart.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/resolver.dart
===================================================================
--- lib/compiler/implementation/resolver.dart (revision 12600)
+++ lib/compiler/implementation/resolver.dart (working copy)
@@ -2615,6 +2615,9 @@
new SourceString(fullConstructorName),
MessageKind.CANNOT_FIND_CONSTRUCTOR,
[fullConstructorName]);
+ } else if (inConstContext &&
ahe 2012/09/21 11:52:21 This isn't right.
ngeoffray 2012/09/21 12:27:30 Added a couple of TODOs.
+ (result.modifiers == null || !result.modifiers.isConst())) {
+ error(diagnosticNode, MessageKind.CONSTRUCTOR_IS_NOT_CONST);
}
return result;
}
« no previous file with comments | « no previous file | lib/compiler/implementation/scanner/listener.dart » ('j') | tests/co19/co19-dart2dart.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698