Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1500)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 10968059: Support for unboxed 64-bit integer bitwise operations and equality on ia32. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: addressed comments, added tests and flags Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language.cc
===================================================================
--- runtime/vm/intermediate_language.cc (revision 12897)
+++ runtime/vm/intermediate_language.cc (working copy)
@@ -1215,6 +1215,16 @@
}
+RawAbstractType* UnboxedMintBinaryOpInstr::CompileType() const {
+ return Type::MintType();
+}
+
+
+intptr_t UnboxedMintBinaryOpInstr::ResultCid() const {
+ return kMintCid;
+}
+
+
RawAbstractType* UnboxedDoubleBinaryOpInstr::CompileType() const {
return Type::Double();
}
@@ -1240,6 +1250,26 @@
}
+intptr_t BoxIntegerInstr::ResultCid() const {
+ return kIntegerCid;
srdjan 2012/09/28 16:50:26 This type is not very helpful. It would be good if
Florian Schneider 2012/10/02 11:10:31 Done. If we don't know anything about the range of
+}
+
+
+RawAbstractType* BoxIntegerInstr::CompileType() const {
+ return Type::IntType();
+}
+
+
+intptr_t UnboxIntegerInstr::ResultCid() const {
+ return kIntegerCid;
srdjan 2012/09/28 16:50:26 ditto. We should use only non-abstract class class
Florian Schneider 2012/10/02 11:10:31 Done.
+}
+
+
+RawAbstractType* UnboxIntegerInstr::CompileType() const {
+ return Type::null();
+}
+
+
RawAbstractType* UnarySmiOpInstr::CompileType() const {
return Type::SmiType();
}

Powered by Google App Engine
This is Rietveld 408576698