Support for unboxed 64-bit integer bitwise operations and equality on ia32.

runtime/vm/flow_graph_compiler_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_X64.
 #if defined(TARGET_ARCH_X64)
 
 #include "vm/flow_graph_compiler.h"
 
 #include "lib/error.h"
 #include "vm/ast_printer.h"
 #include "vm/il_printer.h"
 #include "vm/locations.h"
 #include "vm/object_store.h"
 #include "vm/parser.h"
 #include "vm/stub_code.h"
 #include "vm/symbols.h"
 
 namespace dart {
 
 DECLARE_FLAG(bool, print_ast);
 DECLARE_FLAG(bool, print_scopes);
 DECLARE_FLAG(bool, reject_named_argument_as_positional);
 DECLARE_FLAG(bool, trace_functions);
+DECLARE_FLAG(bool, use_sse41);
+DEFINE_FLAG(bool, trap_on_deoptimization, false, "Trap on deoptimization.");
+// TODO(fschneider): Support unboxed mint arithmetic on x64.
+DEFINE_FLAG(bool, unbox_integers, false, "Optimize 64-bit integer arithmetic.");

[srdjan, 2012/09/28 16:50:26]

Do you need this flag? It will not work on X64 if we enable it, will it? Do you
plan to implement it at all? Maybe just return false in SupportsUnboxedMints.
Maybe we could later have a flag unbox_integers which would unbox mints and
Smi-s.

[Florian Schneider, 2012/10/02 11:10:31]

Done.

+
+
+bool FlowGraphCompiler::SupportsUnboxedMints() {
+  return FLAG_unbox_integers
+      && CPUFeatures::sse4_1_supported()
+      && FLAG_use_sse41;
+}
 
 
 void CompilerDeoptInfoWithStub::GenerateCode(FlowGraphCompiler* compiler,
                                              intptr_t stub_ix) {
   // Calls do not need stubs, they share a deoptimization trampoline.
   ASSERT(reason() != kDeoptAtCall);
   Assembler* assem = compiler->assembler();
 #define __ assem->
   __ Comment("Deopt stub for id %"Pd"", deopt_id());
   __ Bind(entry_label());
+  if (FLAG_trap_on_deoptimization) __ int3();
 
   ASSERT(deoptimization_env() != NULL);
 
   if (compiler->IsLeaf()) {
     __ Comment("Leaf method, lazy PC marker setup");
     // TODO(srdjan): Can we use TMP instead of RAX? We must guarantee that
     // TMP is never part of deoptimization environment.
     __ pushq(RAX);  // Preserve RAX.
     Label L;
     __ call(&L);
@@ skipping 1305 matching lines @@
 void ParallelMoveResolver::Exchange(const Address& mem1, const Address& mem2) {
   __ Exchange(mem1, mem2);
 }
 
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64