Support for unboxed 64-bit integer bitwise operations and equality on ia32.

runtime/vm/disassembler_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/disassembler.h"
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 #include "platform/utils.h"
 #include "vm/allocation.h"
@@ skipping 287 matching lines @@
 
   // Handle special encodings.
   int JumpShort(uint8_t* data);
   int JumpConditional(uint8_t* data, const char* comment);
   int JumpConditionalShort(uint8_t* data, const char* comment);
   int SetCC(uint8_t* data);
   int CMov(uint8_t* data);
   int D1D3C1Instruction(uint8_t* data);
   int F7Instruction(uint8_t* data);
   int FPUInstruction(uint8_t* data);
+  int BitwisePDInstruction(uint8_t* data);
+  int Packed660F38Instruction(uint8_t* data);
   int DecodeEnter(uint8_t* data);
   void CheckPrintStop(uint8_t* data);
 
   // Disassembler helper functions.
   static void GetModRm(uint8_t data, int* mod, int* regop, int* rm) {
     *mod = (data >> 6) & 3;
     *regop = (data & 0x38) >> 3;
     *rm = data & 7;
   }
 
@@ skipping 651 matching lines @@
   } else if (b1 == 0xDA && b2 == 0xE9) {
     const char* mnem = "fucompp";
     Print(mnem);
     return 2;
   }
   Print("Unknown FP instruction");
   return 2;
 }
 
 
+int X86Decoder::BitwisePDInstruction(uint8_t* data) {
+  const char* mnem = (*data == 0x57)
+      ? "xorpd"
+      : (*data == 0x56)
+        ? "orpd"
+        : "andpd";
+  int mod, regop, rm;
+  GetModRm(*(data+1), &mod, &regop, &rm);
+  Print(mnem);
+  Print(" ");
+  PrintXmmRegister(regop);
+  Print(",");
+  return 1 + PrintRightXmmOperand(data+1);
+}
+
+
+int X86Decoder::Packed660F38Instruction(uint8_t* data) {
+  if (*(data+1) == 0x25) {
+    Print("pmovsxdq ");
+    int mod, regop, rm;
+    GetModRm(*(data+2), &mod, &regop, &rm);
+    PrintXmmRegister(regop);
+    Print(",");
+    return 2 + PrintRightXmmOperand(data+2);
+  } else if (*(data+1) == 0x29) {
+    Print("pcmpeqq ");
+    int mod, regop, rm;
+    GetModRm(*(data+2), &mod, &regop, &rm);
+    PrintXmmRegister(regop);
+    Print(",");
+    return 2 + PrintRightXmmOperand(data+2);
+  }
+  UNIMPLEMENTED();

[srdjan, 2012/09/28 16:50:26]

UNREACHABLE() ?

[Florian Schneider, 2012/10/02 11:10:31]

Done.

+  return 1;
+}
+
+
 // Called when disassembling test eax, 0xXXXXX.
 void X86Decoder::CheckPrintStop(uint8_t* data) {
   // Recognize stop pattern.
   if (*reinterpret_cast<uint8_t*>(data + 5) == 0xCC) {
     Print("  STOP:'");
     const char* text = *reinterpret_cast<const char**>(data + 1);
     Print(text);
     Print("'");
   }
 }
@@ skipping 337 matching lines @@
             data++;
           } else if (*data == 0X7E) {
             data++;
             int mod, regop, rm;
             GetModRm(*data, &mod, &regop, &rm);
             Print("movd ");
             PrintCPURegister(rm);
             Print(",");
             PrintXmmRegister(regop);
             data++;
-          } else if (*data == 0x57 || *data == 0x54) {
-            const char* mnem = (*data == 0x57) ? "xorpd" : "andpd";
-            data++;
-            int mod, regop, rm;
-            GetModRm(*data, &mod, &regop, &rm);
-            Print(mnem);
-            Print(" ");
-            PrintXmmRegister(regop);
-            Print(",");
-            data += PrintRightXmmOperand(data);
+          } else if (*data == 0x57 || *data == 0x56 || *data == 0x54) {
+            data += BitwisePDInstruction(data);
           } else if (*data == 0x1F &&
                      *(data+1) == 0x44 &&
                      *(data+2) == 0x00 &&
                      *(data+3) == 0x00) {
             data += 4;
             Print("nop");
           } else if (*data == 0x50) {
             Print("movmskpd ");
             data++;
             int mod, regop, rm;
             GetModRm(*data, &mod, &regop, &rm);
             PrintCPURegister(regop);
             Print(",");
             data += PrintRightXmmOperand(data);
+          } else if (*data == 0x3A &&
+                     *(data+1) == 0x16) {
+            Print("pextrd ");
+            data += 2;
+            int mod, regop, rm;
+            GetModRm(*data, &mod, &regop, &rm);
+            PrintCPURegister(rm);
+            Print(",");
+            PrintXmmRegister(regop);
+            Print(",");
+            PrintHex(*(data+1));
+            data += 2;
+          } else if (*data == 0x38) {
+            data += Packed660F38Instruction(data);
           } else {
             UNIMPLEMENTED();
           }
         } else if (*data == 0x90) {
           data++;
           Print("nop");
         } else {
           UNIMPLEMENTED();
         }
         break;
@@ skipping 270 matching lines @@
                                   human_buffer,
                                   sizeof(human_buffer),
                                   pc);
     pc += instruction_length;
   }
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32