Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: chromeos/dbus/ibus/ibus_engine_service.h

Issue 10968056: Fix crash bug of IME extension API. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix unittest. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/ibus/ibus_engine_service.h
diff --git a/chromeos/dbus/ibus/ibus_engine_service.h b/chromeos/dbus/ibus/ibus_engine_service.h
index a7a11b4c1b83771082f8df5ae55d641b763b530b..af81f9c1a864274e0af13adf26ca50432420a2b2 100644
--- a/chromeos/dbus/ibus/ibus_engine_service.h
+++ b/chromeos/dbus/ibus/ibus_engine_service.h
@@ -130,8 +130,12 @@ class CHROMEOS_EXPORT IBusEngineService {
virtual ~IBusEngineService();
- // Initializes the engine client. This class takes the ownership of |handler|.
- virtual void Initialize(IBusEngineHandlerInterface* handler) = 0;
+ // Sets a new IBus engine client and old client will be overrided.
Seigo Nonaka 2012/09/24 07:52:45 pls also /client/handler/
hsumita 2012/09/24 08:01:16 Done.
+ // This class doesn't take the ownership of |handler|.
+ virtual void SetEngine(IBusEngineHandlerInterface* handler) = 0;
Seigo Nonaka 2012/09/24 07:38:45 I think you may want to update mock_ibus_engine_se
hsumita 2012/09/24 08:01:16 Done.
+
+ // Unsets a current IBus engine client.
Seigo Nonaka 2012/09/24 07:52:45 /client/handler/
hsumita 2012/09/24 08:01:16 Done.
+ virtual void UnsetEngine() = 0;
// Emits RegisterProperties signal.
virtual void RegisterProperties(

Powered by Google App Engine
This is Rietveld 408576698