chrome/browser/resources/shared/js/cr/ui/menu.js - Issue 10966027: Basic keyboard access for recently_closed menu on NTP. Allows using up and down arrows to navigate,…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/shared/js/cr/ui/menu.js

Issue 10966027: Basic keyboard access for recently_closed menu on NTP. Allows using up and down arrows to navigate,… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Get rid of pointless experimental code" Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/ntp4/recently_closed.js ('K') | « chrome/browser/resources/ntp4/recently_closed.js ('k') | chrome/browser/resources/shared/js/cr/ui/menu_button.js » ('j') | chrome/browser/resources/shared/js/cr/ui/menu_button.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/shared/js/cr/ui/menu.js

diff --git a/chrome/browser/resources/shared/js/cr/ui/menu.js b/chrome/browser/resources/shared/js/cr/ui/menu.js

index 3e1e3dc31fc1e0630287a9c9fb6c03d21ed4d8a7..0d6721b0bb0c9ca2dc9d663020569d434b550dc8 100644

--- a/chrome/browser/resources/shared/js/cr/ui/menu.js

+++ b/chrome/browser/resources/shared/js/cr/ui/menu.js

@@ -180,7 +180,10 @@ cr.define('cr.ui', function() {

case 'Enter':

case 'U+0020': // Space

if (item) {

- if (cr.dispatchSimpleEvent(item, 'activate', true, true)) {

+ var activationEvent = cr.doc.createEvent('Event');

+ activationEvent.initEvent('activate', true, true);

+ activationEvent.originalEvent = e;

+ if (item.dispatchEvent(activationEvent)) {

if (item.command)

item.command.execute();

}

@@ -208,8 +211,10 @@ cr.define('cr.ui', function() {

if (oldSelectedItem)

oldSelectedItem.selected = false;

var item = this.selectedItem;

- if (item)

+ if (item) {

item.selected = true;

+ item.focus();

+ }

}

/**