Basic keyboard access for recently_closed menu on NTP. Allows using up and down arrows to navigate,…

chrome/browser/resources/ntp4/recently_closed.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview The recently closed menu: button, model data, and menu.
  */
 
 cr.define('ntp', function() {
   'use strict';
@@ skipping 72 matching lines @@
         a.href = '';
         a.classList.add('recent-window');
         a.textContent = formatTabsText(data.tabs.length);
         a.title = data.tabs.map(function(tab) { return tab.title; }).join('\n');
       } else {
         a.href = data.url;
         a.style.backgroundImage = 'url(chrome://favicon/' + data.url + ')';
         a.textContent = data.title;
       }
 
-      function onClick(e) {
+      function onActivated(e) {
         ntp.logTimeToClick('RecentlyClosed');
         chrome.send('recordAppLaunchByURL',
                     [encodeURIComponent(data.url),
                      ntp.APP_LAUNCH.NTP_RECENTLY_CLOSED]);
         var index = Array.prototype.indexOf.call(a.parentNode.children, a);
-        chrome.send('reopenTab', [data.sessionId, index,
-            e.button, e.altKey, e.ctrlKey, e.metaKey, e.shiftKey]);
+        var orig = e.originalEvent;

[Dan Beam, 2012/09/21 03:44:50]

nit: IMO

var params = [data.sessionId,
              index,
              orig.type == 'click' ? orig.button : 0,  // Explains why.
              orig.altKey,
              orig.ctrlKey,
              orig.metaKey,
              orig.shiftKey];
chrome.send('reopenTab', params);

[aboxhall, 2012/09/21 06:46:00]

Done.

[aboxhall, 2012/09/21 06:46:00]

Done.

+        if (orig.type == 'click') {
+          chrome.send('reopenTab', [data.sessionId, index,
+              orig.button, orig.altKey, orig.ctrlKey, orig.metaKey,
+              orig.shiftKey]);
+        } else {
+          chrome.send('reopenTab', [data.sessionId, index,
+              0, orig.altKey, orig.ctrlKey, orig.metaKey, orig.shiftKey]);
+        }
         // We are likely deleted by this point!
-
+        e.stopPropagation();
         e.preventDefault();
       }
-      a.addEventListener('click', onClick);
+      a.addEventListener('activate', onActivated);

[Dan Beam, 2012/09/21 03:44:50]

I really wish this was [cr:ui:]menu:activate or something instead so people know
on first glance it's synthetic.  I thought there was actually some weird
'activate' event natively (in views, the windows native UI toolkit for chrome,
focus is called activation so it didn't seem that far fetched).

[aboxhall, 2012/09/21 06:46:00]

Should I try to fix that in this CL?

[Dan Beam, 2012/09/21 10:23:48]

Any CL ever would surpass the current plans :P

[aboxhall, 2012/09/24 00:48:52]

I found 45 occurrences of 'activate' under chrome/browser/resources. I think
that fixing this is beyond the scope of this change, but if you like I could
have a go later on.

 
       this.menu.appendChild(a);
       cr.ui.decorate(a, MenuItem);
     },
   };
 
   return {
     RecentMenuButton: RecentMenuButton,
   };
 });