Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1621)

Unified Diff: content/browser/web_contents/web_contents_drag_win.h

Issue 10966023: Fix the crash that could occur when the window is closed while web contents drag is in progress. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_drag_win.h
diff --git a/content/browser/web_contents/web_contents_drag_win.h b/content/browser/web_contents/web_contents_drag_win.h
index 3f1972188a53f625ee36232cc5c3b7b276ce5a32..12685852bedf1c8e0472b16acfa50d6b42ac295b 100644
--- a/content/browser/web_contents/web_contents_drag_win.h
+++ b/content/browser/web_contents/web_contents_drag_win.h
@@ -67,7 +67,11 @@ class CONTENT_EXPORT WebContentsDragWin
ui::OSExchangeData* data);
void PrepareDragForUrl(const WebDropData& drop_data,
ui::OSExchangeData* data);
- void DoDragging(const WebDropData& drop_data,
+ // Returns false if the source window becomes invalid when the drag ends.
+ // This could happens when the window gets destroyed when the drag is still in
+ // progress. No further processing should be done beyond this return point
+ // because the instance has been disposed.
+ bool DoDragging(const WebDropData& drop_data,
WebKit::WebDragOperationsMask ops,
const GURL& page_url,
const std::string& page_encoding,

Powered by Google App Engine
This is Rietveld 408576698