Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: content/browser/web_contents/web_contents_view_android.cc

Issue 10966023: Fix the crash that could occur when the window is closed while web contents drag is in progress. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_view_android.h" 5 #include "content/browser/web_contents/web_contents_view_android.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "content/browser/android/content_view_core_impl.h" 8 #include "content/browser/android/content_view_core_impl.h"
9 #include "content/browser/renderer_host/render_widget_host_view_android.h" 9 #include "content/browser/renderer_host/render_widget_host_view_android.h"
10 #include "content/browser/renderer_host/render_view_host_factory.h" 10 #include "content/browser/renderer_host/render_view_host_factory.h"
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 } 122 }
123 123
124 void WebContentsViewAndroid::StoreFocus() { 124 void WebContentsViewAndroid::StoreFocus() {
125 NOTIMPLEMENTED(); 125 NOTIMPLEMENTED();
126 } 126 }
127 127
128 void WebContentsViewAndroid::RestoreFocus() { 128 void WebContentsViewAndroid::RestoreFocus() {
129 NOTIMPLEMENTED(); 129 NOTIMPLEMENTED();
130 } 130 }
131 131
132 bool WebContentsViewAndroid::IsDoingDrag() const {
133 NOTIMPLEMENTED();
134 return false;
135 }
136
137 void WebContentsViewAndroid::CancelDragAndCloseTab() {
138 NOTIMPLEMENTED();
139 }
140
141 WebDropData* WebContentsViewAndroid::GetDropData() const { 132 WebDropData* WebContentsViewAndroid::GetDropData() const {
142 NOTIMPLEMENTED(); 133 NOTIMPLEMENTED();
143 return NULL; 134 return NULL;
144 } 135 }
145 136
146 bool WebContentsViewAndroid::IsEventTracking() const { 137 bool WebContentsViewAndroid::IsEventTracking() const {
147 NOTIMPLEMENTED(); 138 NOTIMPLEMENTED();
148 return false; 139 return false;
149 } 140 }
150 141
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 // This is called when we the renderer asks us to take focus back (i.e., it has 191 // This is called when we the renderer asks us to take focus back (i.e., it has
201 // iterated past the last focusable element on the page). 192 // iterated past the last focusable element on the page).
202 void WebContentsViewAndroid::TakeFocus(bool reverse) { 193 void WebContentsViewAndroid::TakeFocus(bool reverse) {
203 if (web_contents_->GetDelegate() && 194 if (web_contents_->GetDelegate() &&
204 web_contents_->GetDelegate()->TakeFocus(web_contents_, reverse)) 195 web_contents_->GetDelegate()->TakeFocus(web_contents_, reverse))
205 return; 196 return;
206 web_contents_->GetRenderWidgetHostView()->Focus(); 197 web_contents_->GetRenderWidgetHostView()->Focus();
207 } 198 }
208 199
209 } // namespace content 200 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698