Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py

Issue 10965027: Add web page replay to chrome_remote_control. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Replace CreateForwarder with CreateReplayServer Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py
diff --git a/tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py b/tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py
index f9dc5460db20fc527edb5b4813ac77de8d26700d..00b426439ee019ed2bd6fcd345b0b43671d5d7b2 100644
--- a/tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py
+++ b/tools/chrome_remote_control/chrome_remote_control/desktop_browser_backend.py
@@ -15,7 +15,7 @@ class DesktopBrowserBackend(browser_backend.BrowserBackend):
"""The backend for controlling a locally-executed browser instance, on Linux,
Mac or Windows.
"""
- def __init__(self, options, executable, is_content_shell):
+ def __init__(self, options, executable, is_content_shell, extra_browser_args):
super(DesktopBrowserBackend, self).__init__(is_content_shell)
# Initialize fields so that an explosion during init doesn't break in Close.
@@ -34,11 +34,13 @@ class DesktopBrowserBackend(browser_backend.BrowserBackend):
if not options.dont_override_profile:
self._tmpdir = tempfile.mkdtemp()
args.append('--user-data-dir=%s' % self._tmpdir)
+ if extra_browser_args:
+ args.extend(extra_browser_args)
args.extend(options.extra_browser_args)
if not options.show_stdout:
self._devnull = open(os.devnull, 'w')
self._proc = subprocess.Popen(
- args,stdout=self._devnull, stderr=self._devnull)
+ args, stdout=self._devnull, stderr=self._devnull)
else:
self._devnull = None
self._proc = subprocess.Popen(args)

Powered by Google App Engine
This is Rietveld 408576698