tools/chrome_remote_control/chrome_remote_control/cros_browser_backend.py - Issue 10965027: Add web page replay to chrome_remote_control.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_remote_control/chrome_remote_control/cros_browser_backend.py

Issue 10965027: Add web page replay to chrome_remote_control. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Replace CreateForwarder with CreateReplayServer Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_remote_control/chrome_remote_control/browser_options.py ('k') | tools/chrome_remote_control/chrome_remote_control/cros_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_remote_control/chrome_remote_control/cros_browser_backend.py

diff --git a/tools/chrome_remote_control/chrome_remote_control/cros_browser_backend.py b/tools/chrome_remote_control/chrome_remote_control/cros_browser_backend.py

index a8d3f418788c8b8f502e85cd0f615dda59897fb0..f9367bbbc780ef8dfdbc689d40e265616513fb7d 100644

--- a/tools/chrome_remote_control/chrome_remote_control/cros_browser_backend.py

+++ b/tools/chrome_remote_control/chrome_remote_control/cros_browser_backend.py

@@ -12,7 +12,8 @@ from chrome_remote_control import cros_interface

class CrOSBrowserBackend(browser_backend.BrowserBackend):

"""The backend for controlling a browser instance running on CrOS.

"""

- def __init__(self, browser_type, options, is_content_shell, cri):

+ def __init__(self, browser_type, options, extra_browser_args,

+ is_content_shell, cri):

super(CrOSBrowserBackend, self).__init__(is_content_shell)

# Initialize fields so that an explosion during init doesn't break in Close.

self._options = options

@@ -65,6 +66,8 @@ class CrOSBrowserBackend(browser_backend.BrowserBackend):

args.append('--user-data-dir=%s' % self._tmpdir)

# Final bits of command line prep.

+ if extra_browser_args:

+ args.extend(extra_browser_args)

args.extend(options.extra_browser_args)

prevent_output = not options.show_stdout