Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 10965007: Accept contents from stdin in endure_result_parser.py. (Closed)

Created:
8 years, 3 months ago by Dai Mikurube (NOT FULLTIME)
Modified:
8 years, 2 months ago
Reviewers:
dennis_jeffrey
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Accept contents from stdin in endure_result_parser.py. BUG=chromium-os:32302 NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158959

Patch Set 1 #

Patch Set 2 : nit fix #

Patch Set 3 : fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -98 lines) Patch
M chrome/test/functional/perf/endure_result_parser.py View 1 2 3 chunks +115 lines, -98 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dai Mikurube (NOT FULLTIME)
Hi Dennis, Could you take another look at this? It's a change just for convenience ...
8 years, 2 months ago (2012-09-26 06:26:20 UTC) #1
dennis_jeffrey
LGTM Thanks for moving that large chunk of code into a helper function. I think ...
8 years, 2 months ago (2012-09-26 22:54:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/10965007/5001
8 years, 2 months ago (2012-09-27 01:20:26 UTC) #3
commit-bot: I haz the power
Change committed as 158959
8 years, 2 months ago (2012-09-27 01:20:35 UTC) #4
Dai Mikurube (NOT FULLTIME)
8 years, 2 months ago (2012-09-27 01:20:37 UTC) #5
On 2012/09/26 22:54:15, dennis_jeffrey wrote:
> LGTM
> 
> Thanks for moving that large chunk of code into a helper function.  I think it
> makes sense to separate that out into a separate function.

Thanks.  Checked the "Commit".

Powered by Google App Engine
This is Rietveld 408576698