Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: win8/delegate_execute/delegate_execute_operation.cc

Issue 10962023: Prefix Chrome switches with the switch prefix. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: win8/delegate_execute/delegate_execute_operation.cc
diff --git a/win8/delegate_execute/delegate_execute_operation.cc b/win8/delegate_execute/delegate_execute_operation.cc
index f2ba2c47ac101a103b3dea4c1f7859625e54c732..0f52ace5e21c20ae040b69a3685c02b7db56de51 100644
--- a/win8/delegate_execute/delegate_execute_operation.cc
+++ b/win8/delegate_execute/delegate_execute_operation.cc
@@ -7,13 +7,19 @@
#include "base/command_line.h"
#include "base/string_number_conversions.h"
#include "base/string_split.h"
+#include "base/utf_string_conversions.h"
#include "chrome/common/chrome_switches.h"
+namespace {
+
+const wchar_t kSwitchPrefix[] = L"--";
+
+} // namespace
+
namespace delegate_execute {
DelegateExecuteOperation::DelegateExecuteOperation()
- : operation_type_(DELEGATE_EXECUTE),
- relaunch_flags_("") {
+ : operation_type_(DELEGATE_EXECUTE) {
}
DelegateExecuteOperation::~DelegateExecuteOperation() {
@@ -31,9 +37,11 @@ bool DelegateExecuteOperation::Init(const CommandLine* cmd_line) {
return false;
// Add the mode forcing flags, if any.
if (cmd_line->HasSwitch(switches::kForceDesktop))
- relaunch_flags_ = switches::kForceDesktop;
+ relaunch_flags_ = kSwitchPrefix + ASCIIToWide(switches::kForceDesktop);
else if (cmd_line->HasSwitch(switches::kForceImmersive))
- relaunch_flags_ = switches::kForceImmersive;
+ relaunch_flags_ = kSwitchPrefix + ASCIIToWide(switches::kForceImmersive);
+ else
+ relaunch_flags_.clear();
operation_type_ = RELAUNCH_CHROME;
return true;

Powered by Google App Engine
This is Rietveld 408576698