Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 10962008: High contrast mode support for multiple displays. (Closed)

Created:
8 years, 3 months ago by mtomasz
Modified:
8 years, 2 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

High contrast mode support for multiple displays. All displays are now updated when high contrast mode is changed in settings. Moreover, if a new display is attached, then high contrast setting is applied on it. BUG=150972 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159188

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed code style. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M ash/high_contrast/high_contrast_controller.h View 1 1 chunk +7 lines, -1 line 0 comments Download
M ash/high_contrast/high_contrast_controller.cc View 1 chunk +14 lines, -2 lines 0 comments Download
M ash/shell.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtomasz
@ben PTAL. @zork PTAL.
8 years, 3 months ago (2012-09-20 10:21:05 UTC) #1
Zachary Kuznia
lgtm
8 years, 3 months ago (2012-09-21 05:05:46 UTC) #2
Ben Goodger (Google)
http://codereview.chromium.org/10962008/diff/1/ash/high_contrast/high_contrast_controller.h File ash/high_contrast/high_contrast_controller.h (right): http://codereview.chromium.org/10962008/diff/1/ash/high_contrast/high_contrast_controller.h#newcode33 ash/high_contrast/high_contrast_controller.h:33: void UpdateDisplay(aura::RootWindow* root_window); functions before data.
8 years, 3 months ago (2012-09-21 18:05:41 UTC) #3
mtomasz
@ben PTAL. http://codereview.chromium.org/10962008/diff/1/ash/high_contrast/high_contrast_controller.h File ash/high_contrast/high_contrast_controller.h (right): http://codereview.chromium.org/10962008/diff/1/ash/high_contrast/high_contrast_controller.h#newcode33 ash/high_contrast/high_contrast_controller.h:33: void UpdateDisplay(aura::RootWindow* root_window); On 2012/09/21 18:05:41, Ben ...
8 years, 3 months ago (2012-09-24 02:40:48 UTC) #4
mtomasz
On 2012/09/24 02:40:48, mtomasz wrote: > @ben PTAL. > > http://codereview.chromium.org/10962008/diff/1/ash/high_contrast/high_contrast_controller.h > File ash/high_contrast/high_contrast_controller.h (right): ...
8 years, 2 months ago (2012-09-26 04:49:23 UTC) #5
Ben Goodger (Google)
lgtm
8 years, 2 months ago (2012-09-27 16:23:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/10962008/8004
8 years, 2 months ago (2012-09-28 00:37:59 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-09-28 03:08:11 UTC) #8
Change committed as 159188

Powered by Google App Engine
This is Rietveld 408576698