Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/base/android/media_player_listener.cc

Issue 10961015: Android: MediaPlayerBridge JNI cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/base/android/media_player_bridge.cc ('K') | « media/base/android/media_player_listener.h ('k') | media/media.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_player_listener.cc
diff --git a/media/base/android/media_player_listener.cc b/media/base/android/media_player_listener.cc
index ea70a33101f9e987fff7ad357ded1b6c27843912..de1820190c7b8efe8d649e0ed0fd8f02d5a6f1e7 100644
--- a/media/base/android/media_player_listener.cc
+++ b/media/base/android/media_player_listener.cc
@@ -31,14 +31,13 @@ MediaPlayerListener::MediaPlayerListener(
MediaPlayerListener::~MediaPlayerListener() {}
-ScopedJavaLocalRef<jobject> MediaPlayerListener::CreateMediaPlayerListener() {
+void MediaPlayerListener::CreateMediaPlayerListener(
+ jobject context, jobject media_player) {
JNIEnv* env = AttachCurrentThread();
CHECK(env);
- ScopedJavaLocalRef<jobject> j_listener(
- Java_MediaPlayerListener_create(env, reinterpret_cast<intptr_t>(this)));
- DCHECK(!j_listener.is_null());
- return j_listener;
+ Java_MediaPlayerListener_create(
+ env, reinterpret_cast<intptr_t>(this), context, media_player);
}
void MediaPlayerListener::OnMediaError(
« media/base/android/media_player_bridge.cc ('K') | « media/base/android/media_player_listener.h ('k') | media/media.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698