Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: media/base/android/java/src/org/chromium/media/MediaPlayerListener.java

Issue 10961015: Android: MediaPlayerBridge JNI cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Patch Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/java/src/org/chromium/media/MediaPlayerListener.java
diff --git a/media/base/android/java/src/org/chromium/media/MediaPlayerListener.java b/media/base/android/java/src/org/chromium/media/MediaPlayerListener.java
index dc64bc7bf2340dcd29f5e1432cba3cf376069126..c1b1baba73aed2f6af5e9d9e28f9ee5e14668255 100644
--- a/media/base/android/java/src/org/chromium/media/MediaPlayerListener.java
+++ b/media/base/android/java/src/org/chromium/media/MediaPlayerListener.java
@@ -4,6 +4,7 @@
package org.chromium.media;
+import android.content.Context;
import android.media.MediaPlayer;
import org.chromium.base.CalledByNative;
@@ -83,8 +84,17 @@ class MediaPlayerListener implements MediaPlayer.OnPreparedListener,
}
@CalledByNative
- private static MediaPlayerListener create(int nativeMediaPlayerListener) {
- return new MediaPlayerListener(nativeMediaPlayerListener);
+ private static MediaPlayerListener create(int nativeMediaPlayerListener,
+ Context context, MediaPlayer mediaPlayer) {
+ MediaPlayerListener listener = new MediaPlayerListener(nativeMediaPlayerListener);
+ mediaPlayer.setOnBufferingUpdateListener(listener);
+ mediaPlayer.setOnCompletionListener(listener);
+ mediaPlayer.setOnErrorListener(listener);
+ mediaPlayer.setOnPreparedListener(listener);
+ mediaPlayer.setOnSeekCompleteListener(listener);
+ mediaPlayer.setOnVideoSizeChangedListener(listener);
+ mediaPlayer.setWakeMode(context, android.os.PowerManager.FULL_WAKE_LOCK);
+ return listener;
qinmin 2012/09/20 14:45:21 do we really need to return the listener here? Sin
bulach 2012/09/20 17:53:01 you're right! removed..
}
/**

Powered by Google App Engine
This is Rietveld 408576698