Dump JSON data for stacked graphs in endure_result_parser.py.

Dump JSON data for stacked graphs in endure_result_parser.py.


BUG=122119
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158958

[Dai Mikurube (NOT FULLTIME), 2012-09-20 09:17:30]

http://codereview.chromium.org/10961012/diff/1/chrome/test/functional/perf/en...
File chrome/test/functional/perf/endure_result_parser.py (right):

http://codereview.chromium.org/10961012/diff/1/chrome/test/functional/perf/en...
chrome/test/functional/perf/endure_result_parser.py:260: webapp_name, test_name,
match[0].endswith('-DMP'))
It's temporary.  We need to decide "RESULT" protocol to specify stacked
graphing.

[dennis_jeffrey, 2012-09-26 00:58:06]

http://codereview.chromium.org/10961012/diff/1/chrome/test/functional/perf/en...
File chrome/test/functional/perf/endure_result_parser.py (right):

http://codereview.chromium.org/10961012/diff/1/chrome/test/functional/perf/en...
chrome/test/functional/perf/endure_result_parser.py:137: stack_order: A list
that contains order to stack values in the graph.
is this an array of perf key strings?  If so, maybe we could make that clear in
the description here.

http://codereview.chromium.org/10961012/diff/1/chrome/test/functional/perf/en...
chrome/test/functional/perf/endure_result_parser.py:187: new_line['stack'] =
is_stacked
since we will only include 'stack' in the line if is_stacked is true, we could
just say:

new_line['stack'] = True

http://codereview.chromium.org/10961012/diff/1/chrome/test/functional/perf/en...
chrome/test/functional/perf/endure_result_parser.py:260: webapp_name, test_name,
match[0].endswith('-DMP'))
On 2012/09/20 09:17:30, Dai Mikurube wrote:
> It's temporary.  We need to decide "RESULT" protocol to specify stacked
> graphing.

I think this is ok for now, since we append "-DMP" to any graph names that are
stacked.  Maybe we could add a TODO above this line so we remember to revisit
this in the future if we figure out a better, more permanent way to handle this.

http://codereview.chromium.org/10961012/diff/1/chrome/test/functional/perf/en...
chrome/test/functional/perf/endure_result_parser.py:289:
perf_data[key1]['stack_order'].append(data['description'])
should we only execute lines 286-289 if data['stack'] is True?

[Dai Mikurube (NOT FULLTIME), 2012-09-26 06:11:14]

Thanks for reviewing the change.  Updated.

NOTE: I reordered my changes: this change is now before
http://codereview.chromium.org/10965007/.

http://codereview.chromium.org/10961012/diff/1/chrome/test/functional/perf/en...
File chrome/test/functional/perf/endure_result_parser.py (right):

http://codereview.chromium.org/10961012/diff/1/chrome/test/functional/perf/en...
chrome/test/functional/perf/endure_result_parser.py:137: stack_order: A list
that contains order to stack values in the graph.
On 2012/09/26 00:58:06, dennis_jeffrey wrote:
> is this an array of perf key strings?  If so, maybe we could make that clear
in
> the description here.

Done.

http://codereview.chromium.org/10961012/diff/1/chrome/test/functional/perf/en...
chrome/test/functional/perf/endure_result_parser.py:187: new_line['stack'] =
is_stacked
On 2012/09/26 00:58:06, dennis_jeffrey wrote:
> since we will only include 'stack' in the line if is_stacked is true, we could
> just say:
> 
> new_line['stack'] = True

Done.

http://codereview.chromium.org/10961012/diff/1/chrome/test/functional/perf/en...
chrome/test/functional/perf/endure_result_parser.py:260: webapp_name, test_name,
match[0].endswith('-DMP'))
On 2012/09/26 00:58:06, dennis_jeffrey wrote:
> On 2012/09/20 09:17:30, Dai Mikurube wrote:
> > It's temporary.  We need to decide "RESULT" protocol to specify stacked
> > graphing.
> 
> I think this is ok for now, since we append "-DMP" to any graph names that are
> stacked.  Maybe we could add a TODO above this line so we remember to revisit
> this in the future if we figure out a better, more permanent way to handle
this.

Done.

http://codereview.chromium.org/10961012/diff/1/chrome/test/functional/perf/en...
chrome/test/functional/perf/endure_result_parser.py:289:
perf_data[key1]['stack_order'].append(data['description'])
On 2012/09/26 00:58:06, dennis_jeffrey wrote:
> should we only execute lines 286-289 if data['stack'] is True?

I did it to simplify line 321 (calling OutputPerfData), but line 288-289 were
not required.  Fixed it.

[dennis_jeffrey, 2012-09-26 21:53:29]

LGTM

[Dai Mikurube (NOT FULLTIME), 2012-09-26 22:27:43]

On 2012/09/26 21:53:29, dennis_jeffrey wrote:
> LGTM

Thanks.  Checked the "Commit".

[commit-bot: I haz the power, 2012-09-26 22:29:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/10961012/5001

[commit-bot: I haz the power, 2012-09-27 01:16:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/10961012/5001

[commit-bot: I haz the power, 2012-09-27 01:16:41]

Change committed as 158958