Remove 'shell=True' in Popen and directly execute testserver.py

build/android/pylib/chrome_test_server_spawner.py

Index: build/android/pylib/chrome_test_server_spawner.py
diff --git a/build/android/pylib/chrome_test_server_spawner.py b/build/android/pylib/chrome_test_server_spawner.py
index 1766a7731a644a6d2fe3fc6d595944085ae23491..6220846d06c938112eac3a16a78f6e87df3c0635 100644
--- a/build/android/pylib/chrome_test_server_spawner.py
+++ b/build/android/pylib/chrome_test_server_spawner.py
@@ -207,12 +207,10 @@ class TestServerThread(threading.Thread):
     logging.info('Start running the thread!')
     self.wait_event.clear()
     self._GenerateCommandLineArguments()
-    command = '%s %s' % (
-        os.path.join(constants.CHROME_DIR, 'net', 'tools', 'testserver',
-                     'testserver.py'),
-        ' '.join(self.command_line))
-    logging.info(command)
-    self.process = subprocess.Popen(command, shell=True)
+    command = [os.path.join(constants.CHROME_DIR, 'net', 'tools',
+                            'testserver', 'testserver.py')] + self.command_line
+    logging.info("Running: %s", command)

[bulach, 2012/09/24 10:28:03]

nit: for consistency, use ' rather than "

+    self.process = subprocess.Popen(command)
     if self.process:
       if self.pipe_out:
         self.is_ready = self._WaitToStartAndGetPortFromTestServer()