Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 10960009: Allow multiple performance values in endure_result_parser.py. (Closed)

Created:
8 years, 3 months ago by Dai Mikurube (NOT FULLTIME)
Modified:
8 years, 2 months ago
Reviewers:
dennis_jeffrey
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Allow multiple performance values in endure_result_parser.py. It's similar to http://crrev.com/154247. BUG=122119 NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158744

Patch Set 1 #

Patch Set 2 : fixed #

Total comments: 4

Patch Set 3 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -32 lines) Patch
M chrome/test/functional/perf/endure_result_parser.py View 1 2 6 chunks +40 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dai Mikurube (NOT FULLTIME)
Hi Dennis, Could you take a look as commented at http://codereview.chromium.org/10944003/?
8 years, 3 months ago (2012-09-20 07:03:35 UTC) #1
Dai Mikurube (NOT FULLTIME)
ping, just for reminding.
8 years, 3 months ago (2012-09-24 22:56:29 UTC) #2
dennis_jeffrey
LGTM with 2 nits to consider before submitting. http://codereview.chromium.org/10960009/diff/2001/chrome/test/functional/perf/endure_result_parser.py File chrome/test/functional/perf/endure_result_parser.py (right): http://codereview.chromium.org/10960009/diff/2001/chrome/test/functional/perf/endure_result_parser.py#newcode347 chrome/test/functional/perf/endure_result_parser.py:347: key1 ...
8 years, 2 months ago (2012-09-26 00:34:29 UTC) #3
Dai Mikurube (NOT FULLTIME)
Thanks for reviewing. Fixed. I'll be committing it after your CL is landed. http://codereview.chromium.org/10960009/diff/2001/chrome/test/functional/perf/endure_result_parser.py File ...
8 years, 2 months ago (2012-09-26 02:44:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/10960009/9001
8 years, 2 months ago (2012-09-26 03:39:47 UTC) #5
commit-bot: I haz the power
8 years, 2 months ago (2012-09-26 03:50:50 UTC) #6
Change committed as 158744

Powered by Google App Engine
This is Rietveld 408576698